Skip to content

fix con2d transpose bias by create and init it in build_once #18968

Merged
JiabinYang merged 11 commits intoPaddlePaddle:developfrom
JiabinYang:fix_conv2d_transpost
Aug 28, 2019
Merged

fix con2d transpose bias by create and init it in build_once #18968
JiabinYang merged 11 commits intoPaddlePaddle:developfrom
JiabinYang:fix_conv2d_transpost

Conversation

@JiabinYang
Copy link
Contributor

This PR will fix con2d transpose bias by create in build_once instead of doing it in forward

@JiabinYang JiabinYang requested a review from phlrain August 1, 2019 13:34
phlrain
phlrain previously approved these changes Aug 9, 2019
Copy link
Collaborator

@phlrain phlrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…se, billinearTensorProduct, sequece_conv. fix original_mode not used error on GRUunit. fix sample_weight not set error on NCE. Add ut for all thoese layer
@JiabinYang
Copy link
Contributor Author

This PR will fix con2d transpose bias by create in build_once instead of doing it in forward

And Then we fix problem of #18774 #18703 #19200 , GRUUnit original mode has no effect and add sample weight part for NCE model

guoshengCS
guoshengCS previously approved these changes Aug 26, 2019
kuke
kuke previously approved these changes Aug 26, 2019
Copy link
Contributor

@kuke kuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JiabinYang JiabinYang dismissed stale reviews from kuke and guoshengCS via b0a352d August 26, 2019 09:59
Copy link
Contributor

@kuke kuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JiabinYang JiabinYang merged commit 1ce0a09 into PaddlePaddle:develop Aug 28, 2019
JiabinYang added a commit that referenced this pull request Aug 29, 2019
…aph mode (#19491)

This PR cherry-picked the fix of multiple Layers parameter missing error in dygraph mode,the original one is #18968
@JiabinYang JiabinYang deleted the fix_conv2d_transpost branch January 14, 2021 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants