Skip to content

remove unused cmake file#18744

Merged
luotao1 merged 1 commit intoPaddlePaddle:developfrom
luotao1:remove_unused_cmake
Jul 23, 2019
Merged

remove unused cmake file#18744
luotao1 merged 1 commit intoPaddlePaddle:developfrom
luotao1:remove_unused_cmake

Conversation

@luotao1
Copy link
Contributor

@luotao1 luotao1 commented Jul 23, 2019

remove unused cmake file

  • since we have cmake/external/glog.cmake and cmake/external/gflags.cmake, this PR remove FindGlog.cmake and FindGflags.cmake
  • since enable cpplint, remove go_fmt #15939 remove the check of goformat, this PR remove go related cmake files.

@luotao1 luotao1 requested a review from Xreki July 23, 2019 07:18
Copy link
Contributor

@Xreki Xreki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit 0ae45f0 into PaddlePaddle:develop Jul 23, 2019
@luotao1 luotao1 deleted the remove_unused_cmake branch July 23, 2019 08:12
@luotao1 luotao1 mentioned this pull request Jul 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants