enable cpplint, remove go_fmt#15939
Merged
luotao1 merged 2 commits intoPaddlePaddle:developfrom Feb 27, 2019
luotao1:pre_commit2
Merged
enable cpplint, remove go_fmt#15939luotao1 merged 2 commits intoPaddlePaddle:developfrom luotao1:pre_commit2
luotao1 merged 2 commits intoPaddlePaddle:developfrom
luotao1:pre_commit2
Conversation
Contributor
Author
|
28680c6 will report the cpplint error: https://travis-ci.org/PaddlePaddle/Paddle/builds/498684394#L881 |
test=develop
Contributor
Author
|
@panyx0718 Could you help approve for the |
panyx0718
approved these changes
Feb 27, 2019
This was referenced Jul 23, 2019
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cpplinton travis_cipaddle/scripts/cpplint.py, we usepip install cpplinton both local machine and travis_ciTODO:
cpplinton travis_ci runs in multi-thread, and it will print several same logs when there are errors.related #15907 #15876