Skip to content

remove unused gzstream.cmake#18705

Merged
luotao1 merged 1 commit intoPaddlePaddle:developfrom
luotao1:remove_gzstream
Jul 22, 2019
Merged

remove unused gzstream.cmake#18705
luotao1 merged 1 commit intoPaddlePaddle:developfrom
luotao1:remove_gzstream

Conversation

@luotao1
Copy link
Contributor

@luotao1 luotao1 commented Jul 19, 2019

The gzstream library is used by ctr_reader, since ctr_reader is deleted in #18672, this PR remove gzstream library.

@luotao1 luotao1 requested a review from guru4elephant July 19, 2019 10:34
@luotao1
Copy link
Contributor Author

luotao1 commented Jul 20, 2019

[10:56:28]	[Step 1/1] You must have one RD (luotao1 or chengduoZH or XiaoguangHu01) approval for the cmakelist change! CMakeLists.txt for the management reason of the Compilation parameter.

Copy link
Member

@guru4elephant guru4elephant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 requested a review from chengduoZH July 22, 2019 03:39
Copy link
Contributor

@chengduoZH chengduoZH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit c457a69 into PaddlePaddle:develop Jul 22, 2019
@luotao1 luotao1 deleted the remove_gzstream branch July 22, 2019 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants