remove ctr reader, all functions are satisfied in dataset#18672
Merged
guru4elephant merged 2 commits intoPaddlePaddle:developfrom Jul 18, 2019
Merged
remove ctr reader, all functions are satisfied in dataset#18672guru4elephant merged 2 commits intoPaddlePaddle:developfrom
guru4elephant merged 2 commits intoPaddlePaddle:developfrom
Conversation
test=develop
xsrobin
approved these changes
Jul 17, 2019
gavin1332
pushed a commit
to gavin1332/Paddle
that referenced
this pull request
Jul 18, 2019
…le#18672) * remove ctr reader, all functions are satisfied in dataset
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ctr reader and dataset should be equivalent given ctr task and dataset is a more general module that we can do more things with.
test=develop