Message versioning and translation for ROS#24113
Merged
Conversation
🔎 FLASH Analysispx4_fmu-v5x [Total VM Diff: 152 byte (0.01 %)]px4_fmu-v6x [Total VM Diff: 144 byte (0.01 %)]Updated: 2025-02-05T10:33:52 |
6a3bb95 to
ef7c759
Compare
1 task
GuillaumeLaine
approved these changes
Jan 29, 2025
Contributor
GuillaumeLaine
left a comment
There was a problem hiding this comment.
Works as advertised, this is awesome 👍🏻
This adds "_v" + string(T::MESSAGE_VERSION) to the ROS topic if the message contains a MESSAGE_VERSION field (and the version is non-zero).
ef7c759 to
1b92445
Compare
6eea223 to
dc4dd9d
Compare
dc4dd9d to
0115a0b
Compare
Member
Author
|
Thanks for all the reviews and tests. This is getting ready. |
Contributor
|
@mrpollo good to go from your side? |
mrpollo
approved these changes
Feb 7, 2025
Contributor
|
Good to go |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #23850
I ended up adding a script that copies the translation node and msg files into a ROS workspace. I tested an approach of directly adding PX4 into a workspace, but ran into too many issues (e.g. msg namespace cannot be customized independently, or that there cannot be multiple subprojects if the toplevel directory already contains a CMakeLists.txt).