Skip to content

Conversation

@kuhnroyal
Copy link
Contributor

  • fix enum property with default value not being correctly generated
  • simplify template expression (I know its now more complex due to the enum handling but there is only one branch for @required and this.name)

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

CC @swipesight (2018/09) @jaumard (2018/09) @josh-burton (2019/12) @amondnet (2019/12) @sbu-WBT (2020/12) @kuhnroyal (2020/12) @agilob (2020/12)

* simplify template expression
@auto-labeler
Copy link

auto-labeler bot commented Dec 14, 2020

👍 Thanks for opening this issue!
🏷 I have applied any labels matching special text in your issue.

The team will review the labels and make any necessary changes.

@kuhnroyal kuhnroyal changed the title [dart] Fix enums with default value [bug][dart] Fix enums with default value Dec 14, 2020
@wing328 wing328 added this to the 5.0.0 milestone Dec 15, 2020
@wing328
Copy link
Member

wing328 commented Dec 15, 2020

CircleCI failure already fixed in the master.

@wing328 wing328 merged commit 70e86a0 into OpenAPITools:master Dec 15, 2020
sahanatroam added a commit to sahanatroam/openapi-generator that referenced this pull request Dec 15, 2020
…rator into fix/typescript-axios-basePath

* 'master' of https://github.com/OpenAPITools/openapi-generator:
  [dart] Fix enums with default value (OpenAPITools#8182)
  [dart][dart-dio] Formatting improvements (OpenAPITools#8180)
  update samples
@kuhnroyal kuhnroyal deleted the dart/enum-default-values branch December 15, 2020 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants