[dart][dart-dio] Formatting improvements #8180
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@kuhnroyal 👍 thanks for the PR to improve the code format. We also encourage users to run dartfmt to auto-format the output. |
Contributor
Author
Yes that is best practice! :) But even dartfmt requires a little help sometimes, like trailing commas. These changes are mainly to improve diffs for future PRs. |
* always add trailing commas in arrays and break each line * make variables final * improve API formatting (mainly leading spaces) * remove empty lines and whitespaces * fix formatting of datatype and description and docs * consistently use single quotation marks (dart already does this)
kuhnroyal
force-pushed
the
dart-dio/formatting
branch
from
30cf3d4 to
3aaae9c
Compare
josh-burton
approved these changes
Dec 14, 2020
agilob
approved these changes
Dec 14, 2020
Member
|
CircieCI failure already fixed in the master |
sahanatroam
added a commit
to sahanatroam/openapi-generator
that referenced
this pull request
Dec 15, 2020
…rator into fix/typescript-axios-basePath * 'master' of https://github.com/OpenAPITools/openapi-generator: [dart] Fix enums with default value (OpenAPITools#8182) [dart][dart-dio] Formatting improvements (OpenAPITools#8180) update samples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are only formatting changes to improve readability and diffing in the future.
[dart]
[dart-dio]
dart:ioimport from API templatePR checklist
./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.masterCC @swipesight (2018/09) @jaumard (2018/09) @josh-burton (2019/12) @amondnet (2019/12) @sbu-WBT (2020/12) @kuhnroyal (2020/12) @agilob (2020/12)