-
-
Notifications
You must be signed in to change notification settings - Fork 7.3k
[Dart-dio] Add basic integration testing and fix compile errors #8025
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dart-dio] Add basic integration testing and fix compile errors #8025
Conversation
This basically just fetches dependencies, runs the built_value generator and empty test cases. Even running empty test cases is more than is currently possible and at least finds compile errors. There are compile errors atm which need to be fixed.
* the compile error was `serializerForType(Map<String, int>)` in `StoreApi` which needs to be `serializerForType(Map)` * use final instead of var in response handling
|
@josh-burton I have added a some integration testing and fixed 2 compile errors. One caused by the inline enum support. |
|
Can you please add the following line to https://github.com/OpenAPITools/openapi-generator/blob/master/pom.xml#L1352 so that the CI will run the tests as part of the build? |
|
@kuhnroyal thanks for the PR to add test coverage for the petstore dart-dio client 👍 |
This PR adds a basic integration test to the Dart-dio generator.
There are no real tests for the moment but OpenApi test templates are added which generate empty test cases. Running these empty test cases at least ensures that the generated code compiles.
The PR also fixes 2 compile errors that are now catched due to the tests.
PR checklist
./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.master