-
-
Notifications
You must be signed in to change notification settings - Fork 7.3k
[dart-dio] Fixes errors when deserializing primitive return types #7411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dart-dio] Fixes errors when deserializing primitive return types #7411
Conversation
|
@josh-burton This needs to be |
|
@kuhnroyal whats the difference between |
|
Afaik 2 braces perform HTML escaping and won't work for types like Can you rebase the branch and see if it goes green? So many small fixes for Dart but they don't get merged. |
9ff1790 to
391135b
Compare
|
@josh-burton What is missing to get this merged? |
|
@kuhnroyal I'm still waiting on this to be reviewed. CC @ircecho @swipesight @jaumard @amondnet |
3d1626f to
7aa9b4a
Compare
|
@josh-burton I fixed the same problem in #8025 but your fix makes more sense so I will rebase once this here is merged. |
|
My branch with integration test got merged first. |
|
@josh-burton Can you rebase this please? We are currently merging a lot of PRs so I am sure we can get this in. |
…be deserialized as json
5be2db1 to
348455a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is something wrong here when these types get generated - this was fixed in 7fae4ab
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep just fixing that :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to delete the 4 old files manually.
348455a to
4b3c542
Compare
|
CircleCI failure not related to this change. |
Fixes errors when primitive return types are attempted to be deserialized as json
PR checklist
./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.masterCC: @ircecho @swipesight @jaumard @amondnet