Skip to content

Conversation

@josh-burton
Copy link
Contributor

@josh-burton josh-burton commented Sep 14, 2020

Fixes errors when primitive return types are attempted to be deserialized as json

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

CC: @ircecho @swipesight @jaumard @amondnet

@kuhnroyal
Copy link
Contributor

@josh-burton This needs to be {{{returnType}}} or it will break with primitive lists.

@josh-burton
Copy link
Contributor Author

@kuhnroyal whats the difference between {{returnType}} and {{{returnType}}}? (has always confused me)

@kuhnroyal
Copy link
Contributor

Afaik 2 braces perform HTML escaping and won't work for types like List<String> that's why you mostly see 3 braces for type definitions.

Can you rebase the branch and see if it goes green? So many small fixes for Dart but they don't get merged.

@josh-burton josh-burton force-pushed the dart-dio-primitive-return-type branch from 9ff1790 to 391135b Compare September 22, 2020 09:46
@wing328 wing328 added this to the 5.0.0 milestone Oct 25, 2020
@kuhnroyal
Copy link
Contributor

@josh-burton What is missing to get this merged?

@josh-burton
Copy link
Contributor Author

@kuhnroyal I'm still waiting on this to be reviewed. CC @ircecho @swipesight @jaumard @amondnet

@josh-burton josh-burton force-pushed the dart-dio-primitive-return-type branch from 3d1626f to 7aa9b4a Compare November 24, 2020 19:53
@kuhnroyal
Copy link
Contributor

@josh-burton I fixed the same problem in #8025 but your fix makes more sense so I will rebase once this here is merged.

@kuhnroyal
Copy link
Contributor

My branch with integration test got merged first.
You can now run integration tests with ./mvnw integration-test -f samples/client/petstore/dart-dio/pom.xml

@kuhnroyal
Copy link
Contributor

@josh-burton Can you rebase this please? We are currently merging a lot of PRs so I am sure we can get this in.

@josh-burton josh-burton force-pushed the dart-dio-primitive-return-type branch from 5be2db1 to 348455a Compare December 8, 2020 17:51
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is something wrong here when these types get generated - this was fixed in 7fae4ab

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep just fixing that :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to delete the 4 old files manually.

@josh-burton josh-burton force-pushed the dart-dio-primitive-return-type branch from 348455a to 4b3c542 Compare December 8, 2020 18:02
@wing328
Copy link
Member

wing328 commented Dec 9, 2020

CircleCI failure not related to this change.

@wing328 wing328 merged commit 7fb5e25 into OpenAPITools:master Dec 9, 2020
@wing328 wing328 changed the title [dart-dio] Fixes errors when primitive return types are attempted to … [dart-dio] Fixes errors when deserializing primitive return types Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants