Skip to content

Conversation

@impl
Copy link
Contributor

@impl impl commented Mar 5, 2022

For some buggy configurations, a warning is emitted indicating that for a given request body the corresponding CodegenModel could not be found. When this happens, some generators produce NPEs when writing out example code. This change avoids the NPEs by providing a stub value instead.

This is similar in spirit to #11170, and addresses the same set of generators.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

For some buggy configurations, a warning is emitted indicating that for
a given request body the corresponding CodegenModel could not be found.
When this happens, some generators produce NPEs when writing out example
code. This change avoids the NPEs by providing a stub value instead.
@wing328
Copy link
Member

wing328 commented Mar 5, 2022

LGTM. Thanks for the PR.

@wing328 wing328 merged commit 31f0c65 into OpenAPITools:master Mar 5, 2022
@impl impl deleted the fix-example-generation-missing-request-bodies branch March 8, 2022 08:17
@wing328 wing328 added this to the 6.0.0 milestone Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants