Skip to content

Conversation

@ykitamura-mdsol
Copy link
Contributor

Fix example code generators to not raise java.lang.NullPointerException on clients generation for ruby, crystal, go and powershell.

This PR is to close #11158.

With the YAML file described in the issue (#11158), examples will be like these:

Ruby

api_instance = OpenapiClient::PetsApi.new
request_body = [{ ... }] # Array<Object> | 

Go

func main() {
    requestBody := []map[string]interface{}{map[string]interface{}{ ... }} // []map[string]interface{} | 

Powershell

@{ key_example =  ...  } # SystemCollectionsHashtable[] | 

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328
Copy link
Member

wing328 commented Jan 4, 2022

@ykitamura-mdsol thanks for the fix, which looks good to me.

@wing328 wing328 merged commit 5a61675 into OpenAPITools:master Jan 4, 2022
@wing328 wing328 added this to the 5.4.0 milestone Jan 4, 2022
@ykitamura-mdsol ykitamura-mdsol deleted the fix/examples_for_request_body_with_array branch February 28, 2022 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG][Ruby] Request body with array raises java.lang.NullPointerException

2 participants