Skip to content

fix: gas estimation issue #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

fix: gas estimation issue #101

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1983a22
fix: gas estimation issue
gzeoneth Dec 14, 2023
4aecb6f
format: yarn format
gzeoneth Dec 14, 2023
e86195b
docs: update comment
gzeoneth Jan 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/bridge/AbsInbox.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,7 +297,10 @@ abstract contract AbsInbox is DelegateCallAware, PausableUpgradeable, IInboxBase
revert GasLimitTooLarge();
}

uint256 submissionFee = calculateRetryableSubmissionFee(data.length, block.basefee);
// we use 0 instead of block.basefee to workaround a geth gas estimation quirk where
// the code path (and hence gas usage) would be different depending on block.basefee
// the final behavior is the same since block.basefee is used when 0 is specified to calculateRetryableSubmissionFee
uint256 submissionFee = calculateRetryableSubmissionFee(data.length, 0);
if (maxSubmissionCost < submissionFee)
revert InsufficientSubmissionCost(submissionFee, maxSubmissionCost);

Expand Down