fix: gas estimation issue #101
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yahgwai
reviewed
Dec 15, 2023
src/bridge/AbsInbox.sol
Outdated
|
|
||
| uint256 submissionFee = calculateRetryableSubmissionFee(data.length, block.basefee); | ||
| // block.basefee is used in calculateRetryableSubmissionFee when 0 is specified | ||
| // we use 0 instead of block.basefee to workaround a geth gas estimation quirk |
Collaborator
There was a problem hiding this comment.
I think we sgould improve the comment here by writing what the actual gas estimation quirk is, why this was a problem for us with the branching, and why setting 0 solves that.
yahgwai
approved these changes
Jan 16, 2024
Member
Author
|
no-longer an issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ethereum/go-ethereum#28470 (comment)