Skip to content

Conversation

@rcowsill
Copy link
Contributor

@rcowsill rcowsill commented Aug 9, 2020

As discussed in PR#206, this PR adds a test which verifies the A9 vulnerability is present.

The test tries to create a memo with the content:
[marked XSS](javascript&#58this;alert(1))

...and verifies that the resulting memo contains a link with the expected label/href:
marked XSS / javascript:this;alert(1)

With marked 0.3.6 and later the markdown will be escaped, so the link will be missing from the resulting memo and the test will fail.

@lirantal
Copy link
Collaborator

LGTM, failures on builds are due to signup and other flakey flows.
thanks @rcowsill 👍

@lirantal lirantal merged commit d91d4c1 into OWASP:feature/187 Aug 10, 2020
@rcowsill rcowsill deleted the feature/a9-test branch August 10, 2020 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants