-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Restore A9 vulnerability #206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The "A9 Insecure Components" example requires [email protected]; that's the newest version affected by the XSS described in the tutorial
|
Good catch! 👏 |
|
@UlisesGascon do you know anything about flakiness of tests? |
UlisesGascon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
|
Yeah @lirantal seems like there are some issues with the timeouts in the Cypress flow. I will re-run the test for now, but I will tweak the Cypress setup soon :) |
|
Cool, thanks! |
|
Speaking of tests, I was considering adding one to verify that the A9 vulnerability is present. It's basically the |
|
@rcowsill yeah that would be a great idea. let me merge this one PR so we don't hold up on it and you can send a new one with the test. |
|
Great! I'll look into adding the test sometime this weekend. |
The
A9 - Insecure Componentsexample requires [email protected]; that's the newest version affected by the XSS described in the tutorial. After A9 was implemented the package.json got updated to use [email protected], and that stopped the example exploit from working.This changes the package.json to specify [email protected] so the tutorial example works as expected.
Fixes #199