-
Notifications
You must be signed in to change notification settings - Fork 5
Post-kriging apportionment refactoring #361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Post-kriging apportionment refactoring #361
Conversation
for more information, see https://pre-commit.ci
…cca/echopop into refactor_cropping_mesh
…rate downstream bugs
…latitude_intervals`.
for more information, see https://pre-commit.ci
…efactor_apportionment
for more information, see https://pre-commit.ci
…cca/echopop into refactor_apportionment
leewujung
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@brandynlucca : Thanks for the PR. I added a few comments. I read through the code for some of the functions, but not all.
Two of my comments are about the function names - IMHO these two functions have limited use case and can be renamed to reflect the operations they are designed to do:
standardize_kriged_estimatesdistributes unaged estimates to aged estimates according to previously calculated aged proportionscombine_population_tables: combined aged and distributed unaged and already aged estimates.
I've also made notes in #369 re changing these to use xarray dataset/data variables operations.
Other than these and my other small questions, I think this PR is ready to be merged.
…was removed from function signature of `get_proportions.number_proportions`
…g mesh strataum index name
…e in workflow. Should assume that "biomass" is present in function
…cca/echopop into refactor_apportionment
This includes the post-processing performed on the kriged mesh population estimates, which achieves the following steps:
This PR also includes a function for removing specimen-specific haul numbers from the catch data. This avoids incidentally double-counting haul weights where an entire haul's catch was represented in the specimen station dataset and not binned length station data.
All functions are accompanied by corresponding
pytestfunctions and fixtures.coverageclocks in with 92%, with all misses pointing to interspersed validation lines that raise Errors (e.g. missing columns) that were retained from earlier debugging.