-
Notifications
You must be signed in to change notification settings - Fork 5
Refactor age-1 (and other group) partitioning of NASC, abundance, and biomass #370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor age-1 (and other group) partitioning of NASC, abundance, and biomass #370
Conversation
for more information, see https://pre-commit.ci
…cca/echopop into refactor_cropping_mesh
…rate downstream bugs
…latitude_intervals`.
for more information, see https://pre-commit.ci
…ca/echopop into refactor_age1_removal
…should never be expected to be multi-dimensional/multi-indexed.
|
This integrates responses to suggested edits and comments from #355 with those specific to this open PR. Relevant changes:
|
leewujung
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made a few inline comments that require some changes, but I think this PR is ready to be merged once those are addressed.
I made a note in #369 (comment) for incorporating xarray ND representation that will make the calculations more straightforward for the various slicing operations.
…efactor_age1_removal
for more information, see https://pre-commit.ci
…ca/echopop into refactor_age1_removal
for more information, see https://pre-commit.ci
…ca/echopop into refactor_age1_removal
for more information, see https://pre-commit.ci
…s to avoid partial evaluation
…ca/echopop into refactor_age1_removal
for more information, see https://pre-commit.ci
This PR includes:
This PR overlaps with #355. This was done for easier downstream testing to make sure that there were no ill effects from the updated code.