Lint HTML and markdown with prettier #2052
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matentzn
approved these changes
Aug 26, 2022
Contributor
matentzn
left a comment
matentzn
left a comment
There was a problem hiding this comment.
Man this is awesome, I was always wondering about markdown linters, and here is my answer. I checked every single file with an 87% rigour, and it looked great. I have two questions and they are not blockers on merging this, but I will wait for a moment for you to answer before merging.
Contributor
|
Awesome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR runs
npx prettier --write .to reformat HTML and markdown in a principled, deterministic way. This will make it easier to make updates that have smaller diffs, such as #2042. It adds a note on how to do this in the README-sitedev.mdIt also adds a
.prettierignorefile that lists some file types and directories to ignore.This PR does not change how anything looks on the website. However, in 3 cases (see 5ec2d01) it fixes some invalid HTML.