Skip to content

migrate tests from nbs to pytest#502

Merged
deven367 merged 84 commits intomainfrom
rm-nbdev
Aug 12, 2025
Merged

migrate tests from nbs to pytest#502
deven367 merged 84 commits intomainfrom
rm-nbdev

Conversation

@deven367
Copy link
Copy Markdown
Collaborator

@deven367 deven367 commented Jul 8, 2025

Description

Checklist:

  • This PR has a meaningful title and a clear description.
  • The tests pass.
  • All linting tasks pass.
  • The notebooks are clean.

This PR attempts to remove nbdev from the library, there by removing nbdev and fastcore

cc @goodwanghan

Edit:

  • remove nbs folder
  • migrate from numpy to google style docstrings
  • have a single pyproject.toml instead of setup.py and settings.ini
  • remove nbdev related workflows
  • minor cosmetic changes wrt linting and code formatting
  • add test coverage
  • change versioning logic
  • update docs

@deven367 deven367 requested a review from jmoralez as a code owner July 8, 2025 15:44
@review-notebook-app
Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Jul 8, 2025

CodSpeed Performance Report

Merging #502 will not alter performance

Comparing rm-nbdev (5b563ec) with main (f674b45)1

🎉 Hooray! pytest-codspeed just leveled up to 4.0.0!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

✅ 12 untouched benchmarks

Footnotes

  1. No successful run was found on main (b40a2fa) during the generation of this report, so f674b45 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Jul 16, 2025

CLA assistant check
All committers have signed the CLA.

Copy link
Copy Markdown

@goodwanghan goodwanghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

To clarify, we had a lot of offline discussion of the changes, as can be seen from the iterations.

@deven367 deven367 merged commit 965fc85 into main Aug 12, 2025
21 checks passed
@deven367 deven367 deleted the rm-nbdev branch August 12, 2025 12:56
@deven367 deven367 mentioned this pull request Aug 21, 2025
4 tasks
Satyajit-Chaudhuri pushed a commit to Satyajit-Chaudhuri/mlforecast that referenced this pull request Nov 19, 2025
Co-authored-by: elephaint <osprangers@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants