Skip to content

Conversation

@dotlambda
Copy link
Member

@dotlambda dotlambda commented Oct 24, 2025

Diff: rhelmot/aiotarfile@v0.5.1...v0.5.2

Changelog: https://github.com/rhelmot/aiotarfile/commits/v0.5.2

part of

closes #455298

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@bengsparks
Copy link
Contributor

Shall we stick to #455298? It also includes a changelog correction

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 6.topic: python Python is a high-level, general-purpose programming language. labels Oct 24, 2025
@dotlambda
Copy link
Member Author

It also includes a changelog correction

So does this, including some other cleanups.

@bengsparks
Copy link
Contributor

Ok, because you have more tweaks to this package, but please review the pull request tracker next time first, so that efforts arent duplicated. I'll close mine instead.

@dotlambda
Copy link
Member Author

Sorry about that!

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Oct 24, 2025
@bengsparks bengsparks added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Oct 24, 2025
@bengsparks
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 455304
Commit: 715a86abe3b40912b96370f35dc99330d3c776e5


aarch64-linux

✅ 4 packages built:
  • python312Packages.aiotarfile
  • python312Packages.aiotarfile.dist
  • python313Packages.aiotarfile
  • python313Packages.aiotarfile.dist

aarch64-darwin

✅ 4 packages built:
  • python312Packages.aiotarfile
  • python312Packages.aiotarfile.dist
  • python313Packages.aiotarfile
  • python313Packages.aiotarfile.dist

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Oct 24, 2025
@niklaskorz niklaskorz added this pull request to the merge queue Oct 24, 2025
Merged via the queue into NixOS:master with commit c132f67 Oct 24, 2025
34 of 38 checks passed
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Oct 24, 2025

Successfully created backport PR for release-25.05:

@github-actions github-actions bot added the 8.has: port to stable This PR already has a backport to the stable release. label Oct 24, 2025
@dotlambda dotlambda deleted the python3Packages.aiotarfile branch October 24, 2025 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1.severity: security Issues which raise a security issue, or PRs that fix one 6.topic: python Python is a high-level, general-purpose programming language. 8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons. backport release-25.05 Backport PR automatically

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants