[KV Connector][Metrics] Add prometheus metrics support to multi-connector #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
xref vllm-project#26811 |
markmc
force-pushed
the
multi-connector-prometheus
branch
from
b56aaae to
e63b0b5
Compare
NickLucche
reviewed
Oct 24, 2025
Owner
NickLucche
left a comment
NickLucche
left a comment
There was a problem hiding this comment.
pre-commit failures @markmc
Author
I'm a bit puzzled by them - don't get them locally. Will try to look again before EOD |
…ctor Signed-off-by: Mark McLoughlin <[email protected]>
markmc
force-pushed
the
multi-connector-prometheus
branch
from
e63b0b5 to
3416c80
Compare
Author
Amazing! It helps if I commit the fix! 🤣 |
Owner
|
We could probably unit test this one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forgot about the multi-connector!