fix unbounded recursion in Varnode::eraseDescend #8626
+12
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved to a bounds-checked search in Varnode::eraseDescend (Ghidra/Features/Decompiler/src/decompile/cpp/varnode.cc:316) so the descendant list is only mutated when the requested PcodeOp is actually present, preventing invalid std::list::erase calls that previously corrupted the allocator and triggered the segfault. Builds compiled with OPACTION_DEBUG will now throw a LowlevelError if an unexpected removal is attempted, preserving diagnostics without crashing release builds. Fixes issue NationalSecurityAgency#7321
ryanmkurtz
added
Feature: Decompiler
Status: Triage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved to a bounds-checked search in Varnode::eraseDescend (Ghidra/Features/Decompiler/src/decompile/cpp/varnode.cc:316) so the descendant list is only mutated when the requested PcodeOp is actually present, preventing invalid std::list::erase calls that previously corrupted the allocator and triggered the segfault.
Builds compiled with OPACTION_DEBUG will now throw a LowlevelError if an unexpected removal is attempted, preserving diagnostics without crashing release builds.
Fixes issue #7321
Note: the sample provided in #7321 and the one described in #7321 (comment) do not reliably trigger a segfault. Not sure how to to unit-test / integration-test this one.