Skip to content

fix unbounded recursion in Varnode::eraseDescend #8626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+12 −6
Open

fix unbounded recursion in Varnode::eraseDescend #8626

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions Ghidra/Features/Decompiler/src/decompile/cpp/varnode.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,13 +316,19 @@ void Varnode::printInfo(ostream &s) const
void Varnode::eraseDescend(PcodeOp *op)

{
list<PcodeOp *>::iterator iter;
list<PcodeOp *>::iterator iter = descend.begin();

iter = descend.begin();
while (*iter != op) // Find this op in list of vn's descendants
iter++;
descend.erase(iter); // Remove it from list
setFlags(Varnode::coverdirty);
while(iter != descend.end()) { // Find this op in list of vn's descendants
if (*iter == op) {
descend.erase(iter); // Remove it from list
setFlags(Varnode::coverdirty);
return;
}
++iter;
}
#ifdef OPACTION_DEBUG
throw LowlevelError("Attempted to erase non-existent PcodeOp descendant");
#endif
}

/// Put a new operator in the descendant list and set the cover dirty flag
Expand Down