Allow Modeling Two Speed & Var Speed Geothermal Heat Pumps by yzhou601 · Pull Request #1878 · NatLabRockies/OpenStudio-HPXML

yzhou601 · 2024-11-08T03:43:13Z

Pull Request Description

Adds an "experimental" geothermal heat pump model that allows two and variable speed systems. Breaking change: Compressor type input is required.

Calculate two speed system performance curve coefficients from catalog data, using E+ CurveFitTool.
Add two speed ghp system model to OS-HPXML
Calculate variable speed system performance curve coefficients from catalog data, using E+ CurveFitTool.
Add variable speed ghp system model to OS-HPXML
~~Default number of speeds based on efficiency~~ Require CompressorType input
Allow desuperheater to work with new GSHP coil object Allow water heater desuperheater with Coil:Cooling:WaterToAirHeatPump:VariableSpeedEquationFit EnergyPlus#10945 (Not in this PR, this PR is targeted to be merged before new OS/E+)
Address pump flow rate

Checklist

Not all may apply:

Schematron validator (EPvalidator.xml) has been updated
Sample files have been added/updated (openstudio tasks.rb update_hpxmls)
Tests have been added/updated (e.g., HPXMLtoOpenStudio/tests/test*.rb and/or workflow/tests/test*.rb)
Documentation has been updated
Changelog has been updated
openstudio tasks.rb update_measures has been run
No unexpected changes to simulation results of sample files

HPXMLtoOpenStudio/resources/hvac.rb

…o ghp-two-speed-var-speed

yzhou601 · 2024-12-13T20:03:35Z

Update: Performance curve coefficients for two speed systems are completed.

…o ghp-two-speed-var-speed

…uts added.

HPXMLtoOpenStudio/resources/hvac.rb

…ed conditions, added more inputs, a few questions, store progress

yzhou601 · 2025-01-07T22:27:12Z

HPXMLtoOpenStudio/resources/hvac_sizing.rb

@@ -2807,23 +2807,37 @@ def self.apply_hvac_equipment_adjustments(mj, runner, hvac_sizings, weather, hva

      gshp_coil_bf = 0.0806


We can look at E+ bypass factor calculations.

…o ghp-two-speed-var-speed

…ch speed

…low quadratic curves (fixed coefficients orders, and fixed some curves that are not normalized).

…o ghp-two-speed-var-speed

HPXMLtoOpenStudio/tests/test_hvac_sizing.rb

…o ghp-two-speed-var-speed

BuildResidentialHPXML/measure.rb

…o ghp-two-speed-var-speed

shorowit

There was a lot to review here. I didn't really look at or scrutinize the new model's performance maps but tried to look at pretty much everything else.

BuildResidentialHPXML/README.md

BuildResidentialHPXML/measure.rb

Changelog.md

HPXMLtoOpenStudio/measure.xml

HPXMLtoOpenStudio/resources/model.rb

HPXMLtoOpenStudio/tests/test_hvac_sizing.rb

docs/source/workflow_inputs.rst

workflow/tests/base_results/results_simulations_energy.csv

Co-authored-by: Scott Horowitz <scott.horowitz@nrel.gov>

…nStudio-HPXML into ghp-two-speed-var-speed

…o ghp-two-speed-var-speed

…var speed

…o ghp-two-speed-var-speed

jmaguire1 · 2025-04-24T17:25:08Z

@shorowit: I think this is now where we want to land in terms of PLR curves, no impact on the base case because it's still a little uncertain and impactful but we'll keep it for ResStock and document this as being a potential known issue and/or how exactly we're doing our PLR curves here.

If you want to make any other changes (like making this an undocumented feature or changing some of the names around so as not to mislead anyone), let me and @yzhou601 know.

HPXMLtoOpenStudio/resources/hvac_sizing.rb

Changelog.md

…nStudio-HPXML into ghp-two-speed-var-speed

…o ghp-two-speed-var-speed

…nStudio-HPXML into ghp-two-speed-var-speed

…o ghp-two-speed-var-speed

docs/source/workflow_inputs.rst

shorowit

It looks good to me. Thanks @yzhou601 and @jmaguire1! Will merge assuming the CI is happy with the latest changes.

added test files, create coil object with placeholders

100e02a

yzhou601 self-assigned this Nov 8, 2024

jmaguire1 reviewed Nov 20, 2024

View reviewed changes

HPXMLtoOpenStudio/resources/hvac.rb Outdated Show resolved Hide resolved

Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML int…

6c0629b

…o ghp-two-speed-var-speed

yzhou601 added the enhancement New feature or request label Dec 13, 2024

yzhou601 added 4 commits December 19, 2024 11:07

Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML int…

f41d4f1

…o ghp-two-speed-var-speed

fix issues, add heating coil object

74e100c

Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML int…

0788320

…o ghp-two-speed-var-speed

added performance curves for two speed gshp, more assumptions and inp…

346d8c9

…uts added.

shorowit reviewed Dec 27, 2024

View reviewed changes

HPXMLtoOpenStudio/resources/hvac.rb Show resolved Hide resolved

updated performance curves, capacity ratios, cfm/tons based on E+ rat…

2182a8f

…ed conditions, added more inputs, a few questions, store progress

yzhou601 commented Jan 7, 2025

View reviewed changes

yzhou601 added 10 commits January 8, 2025 17:35

Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML int…

cba4f31

…o ghp-two-speed-var-speed

hvac sizing cleanups for two speed GSHP, added rated cop ratios at ea…

4615f89

…ch speed

bugfix

c883e62

Added temperature max/min values to curves, fixed airflow and water f…

ed642d8

…low quadratic curves (fixed coefficients orders, and fixed some curves that are not normalized).

Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML int…

58e8142

…o ghp-two-speed-var-speed

bugfixes, installation quality program(haven't finished yet)

7facd88

Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML int…

b1512e2

…o ghp-two-speed-var-speed

oops, remove debugging statements

d1d0cc8

Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML int…

ab22fcc

…o ghp-two-speed-var-speed

fix sizing unit test

1010b16

yzhou601 commented Jan 17, 2025

View reviewed changes

HPXMLtoOpenStudio/tests/test_hvac_sizing.rb Outdated Show resolved Hide resolved

yzhou601 and others added 4 commits January 17, 2025 15:20

iq ems

7cabcbc

Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML int…

302d4a8

…o ghp-two-speed-var-speed

fix test validation

ec12831

Latest results.

f7b74a3

joseph-robertson reviewed Feb 19, 2025

View reviewed changes

BuildResidentialHPXML/measure.rb Show resolved Hide resolved

Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML int…

00aa08d

…o ghp-two-speed-var-speed

shorowit reviewed Apr 18, 2025

View reviewed changes

yzhou601 and others added 8 commits April 21, 2025 09:48

Update docs/source/workflow_inputs.rst

b33da16

Co-authored-by: Scott Horowitz <scott.horowitz@nrel.gov>

Update Changelog.md

fb59140

Co-authored-by: Scott Horowitz <scott.horowitz@nrel.gov>

Address comments

1485a60

Merge branch 'ghp-two-speed-var-speed' of https://github.com/NREL/Ope…

ae37284

…nStudio-HPXML into ghp-two-speed-var-speed

Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML int…

b09b416

…o ghp-two-speed-var-speed

clean up hvac sizing, revert plr curve for simple model and advanced …

682c4f5

…var speed

Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML int…

8cf2c44

…o ghp-two-speed-var-speed

Latest results.

db6c22d

shorowit reviewed Apr 24, 2025

View reviewed changes

HPXMLtoOpenStudio/resources/hvac_sizing.rb Outdated Show resolved Hide resolved

shorowit reviewed Apr 24, 2025

View reviewed changes

Changelog.md Outdated Show resolved Hide resolved

shorowit and others added 5 commits April 24, 2025 14:30

Super tiny cleanup of a few things. [ci skip]

3f6adad

address comments

a75b331

Merge branch 'ghp-two-speed-var-speed' of https://github.com/NREL/Ope…

749b76e

…nStudio-HPXML into ghp-two-speed-var-speed

Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML int…

bb50cf7

…o ghp-two-speed-var-speed

Latest results.

135100a

yzhou601 requested a review from shorowit April 25, 2025 19:37

yzhou601 and others added 5 commits April 25, 2025 14:19

intermittent pump for all

a4994f0

Merge branch 'ghp-two-speed-var-speed' of https://github.com/NREL/Ope…

113cb84

…nStudio-HPXML into ghp-two-speed-var-speed

rename simple to standard, fix unit test

22917ab

Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML int…

70b5f0c

…o ghp-two-speed-var-speed

Just a few minor things.

279ba39

yzhou601 commented Apr 25, 2025

View reviewed changes

docs/source/workflow_inputs.rst Show resolved Hide resolved

Couldn't help myself, just a little code simplification.

263e4c7

shorowit approved these changes Apr 25, 2025

View reviewed changes

shorowit merged commit 090a26a into master Apr 25, 2025
7 checks passed

shorowit deleted the ghp-two-speed-var-speed branch April 25, 2025 23:04

github-project-automation bot moved this from In progress to Done in OpenStudio-HPXML Apr 25, 2025

joseph-robertson mentioned this pull request Apr 28, 2025

Latest OS-HPXML NatLabRockies/resstock#1368

Merged

32 tasks

		@@ -2807,23 +2807,37 @@ def self.apply_hvac_equipment_adjustments(mj, runner, hvac_sizings, weather, hva

		gshp_coil_bf = 0.0806

Conversation

yzhou601 commented Nov 8, 2024 • edited by shorowit Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Description

Checklist

Uh oh!

Uh oh!

yzhou601 commented Dec 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

yzhou601 Jan 7, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

shorowit left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jmaguire1 commented Apr 24, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

shorowit left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

yzhou601 commented Nov 8, 2024 •

edited by shorowit

Loading

yzhou601 commented Dec 13, 2024 •

edited

Loading