Allow water heater desuperheater with Coil:Cooling:WaterToAirHeatPump:VariableSpeedEquationFit

[yzhou601]

Pull request overview

• Fixes #ISSUENUMBERHERE

Description of the purpose of this PR

Pull Request Author

• Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
• Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
• Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
• Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
• If any diffs are expected, author must demonstrate they are justified using plots and descriptions
• If changes fix a defect, the fix should be demonstrated in plots and descriptions
• If any defect files are updated to a more recent version, upload new versions here or on DevSupport
• If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
• If structural output changes, add to output rules file and add OutputChange label
• If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies

Reviewer

• Perform a Code Review on GitHub
• If branch is behind develop, merge develop and build locally to check for side effects of the merge
• If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
• If feature, test running new feature, try creative ways to break it
• CI status: all green or justified
• Check that performance is not impacted (CI Linux results include performance check)
• Run Unit Test(s) locally
• Check any new function arguments for performance impacts
• Verify IDF naming conventions and styles, memos and notes and defaults
• If new idf included, locally check the err file and other outputs

[yzhou601]

Local test files comparing the results w and w/o desuperheater:

Desuperheater coil is working, the heating energy was subtracted from water-to-air cooling coil source energy.
There's a storage tank connected to desuperheater serving as a preheat tank in the test file, and the temperature of these two tanks look like:

The results look good to me.
@Myoldmopar Let me know if we need to add a new E+ IDF file to the repository or is the unit test sufficient, if so it's ready for review.

[github-actions]

⚠️ Regressions detected on macos-14 for commit ca5aaac

Regression Summary

• ESO Big Diffs: 1

• View Results
• Download Regressions

[github-actions]

⚠️ Regressions detected on macos-14 for commit 183087c

Regression Summary

• ESO Big Diffs: 1

• View Results
• Download Regressions

[yzhou601]

The CI diffs are caused by changing the QSource to subtract the heat being reclaimed for air-to-air DX coils, I did this for single-speed water-to-air coils in #7251, and I felt there's no reason that the air source DX coils not to subtract the reclaimed heat. Let me know if this makes sense.

[Myoldmopar]

I'm good with this. Glad it got wrapped up since we had already gotten the IDD change in. I'll give it a quick sanity check locally with latest develop now.

[Myoldmopar]

All good, merging. Thanks @yzhou601

[Myoldmopar]

OK, so this PR was passing 100% before merging. I pulled develop in and re-ran release testing, and it passed 100%. However, after the merge, a couple failures popped up in the debug tests. I'm rebuilding for debug now and will see.