-
Notifications
You must be signed in to change notification settings - Fork 808
probe: Add more unreal pkghallu targets #1480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jmartin-tech
merged 5 commits into
NVIDIA:main
from
leondz:update/pkghallu_unreal_targets
Nov 19, 2025
Merged
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
b6d52a3
increase fictional pkghallu targets from 1 to 11
leondz 6aa0a81
add task to request templates, add more request templates
leondz 8ada53b
reduce dupe use of 'unit'
leondz 14ec6ad
pkghallu follows soft_prompt_probe_cap
leondz c0b0e2e
allow prompt cap in packagehallucination
jmartin-tech File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @leondz ! This line adds prompt capping, but the test in
tests/probes/test_probes_packagehallucination.pydoesn't expect it and testtest_promptcountfails.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fun this another case where the test env is masking stored state, this test passes in the full suite and fails when executed in isolation.