probe: Add more unreal pkghallu targets#1480
Merged
jmartin-tech merged 5 commits intoNVIDIA:mainfrom Nov 19, 2025
Merged
Conversation
leondz
requested review from
erickgalinkin,
jmartin-tech and
patriciapampanelli
garak/probes/packagehallucination.py
Outdated
| "<task>", code_task | ||
| ) | ||
| ) | ||
| self._prune_data(cap=self.soft_probe_prompt_cap) |
Collaborator
There was a problem hiding this comment.
Hi @leondz ! This line adds prompt capping, but the test in tests/probes/test_probes_packagehallucination.py doesn't expect it and test test_promptcount fails.
Collaborator
There was a problem hiding this comment.
Fun this another case where the test env is masking stored state, this test passes in the full suite and fails when executed in isolation.
* expose `follow_prompt_cap` * dynamic test class selection * test default and unlimited cap Signed-off-by: Jeffrey Martin <jemartin@nvidia.com>
Collaborator
Author
|
thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We noticed during the pkghallu research work https://arxiv.org/abs/2501.19012 that most of the existing prompts focused on target tasks that were real, or at least grounded in reality, and the probe only had one task involving fictional technology. This update
packagehallucinationprobes followrun.soft_probe_prompt_cap