Make __cccl_is_floating_point_v consistent with __cccl_is_integer_v#6952
Conversation
|
Does the PR actually change anything beyond a few renamings? |
|
@bernhardmgruber no, I think it could be useful in #6951 if we want cv unqualified |
|
|
||
| template <class _Tp> | ||
| inline constexpr bool is_floating_point_v = __cccl_is_floating_point_helper_v<remove_cv_t<_Tp>>; | ||
| inline constexpr bool is_floating_point_v = __cccl_is_floating_point_v<remove_cv_t<_Tp>>; |
There was a problem hiding this comment.
@davebayer but the old implementation already did remove_cv_t, so what's the new behavior of this PR?
There was a problem hiding this comment.
I think the purpose of the PR is to make the naming consistent, which makes sense
There was a problem hiding this comment.
It's just to make __cccl_is_floating_point_v usable in the codebase
There was a problem hiding this comment.
Ahh, I thought you meant is_floating_point_v. Sorry, all good!
There was a problem hiding this comment.
It's just a cosmetic change..
This comment has been minimized.
This comment has been minimized.
🥳 CI Workflow Results🟩 Finished in 4h 43m: Pass: 100%/91 | Total: 3d 23h | Max: 3h 09m | Hits: 23%/215191See results here. |
4 participants
We have
__cccl_is_integer_vwhich checks if a type is cv unqualified integer type. Let's have the same thing for floating point types.