Merged
Conversation
Contributor
RAMitchell
commented
Dec 11, 2025
RAMitchell
commented
- Add generate_canonical to random header, add basic test.
- Rename libcpp assertions to cccl
davebayer
requested changes
Dec 11, 2025
davebayer
reviewed
Dec 11, 2025
Comment on lines
+50
to
+51
| inline constexpr bool __cccl_random_is_valid_inttype = | ||
| ::cuda::std::__cccl_is_integer_v<_Type> && !::cuda::std::is_const_v<_Type>; |
Contributor
There was a problem hiding this comment.
!::cuda::std::is_const_v<_Type> is not necessary, __cccl_is_integer_v already requires the type to be cv-unqualified
Contributor
There was a problem hiding this comment.
well, at this point, I would use __cccl_is_integer_v directly
| #endif // _CCCL_HAS_LONG_DOUBLE() | ||
| template <class _Type> | ||
| inline constexpr bool __cccl_random_is_valid_realtype = | ||
| ::cuda::std::is_floating_point_v<_Type> && !::cuda::std::is_const_v<_Type>; |
Contributor
There was a problem hiding this comment.
If you wait for #6952, you can just use __cccl_is_floating_point_v, which will be cv uqualified :)
Contributor
There was a problem hiding this comment.
same here, we can replace __cccl_random_is_valid_realtype with __cccl_is_floating_point_v
Contributor
Author
There was a problem hiding this comment.
Thanks, have updated that.
This comment has been minimized.
This comment has been minimized.
davebayer
reviewed
Dec 12, 2025
davebayer
approved these changes
Dec 12, 2025
This comment has been minimized.
This comment has been minimized.
Contributor
🥳 CI Workflow Results🟩 Finished in 2h 04m: Pass: 100%/91 | Total: 1d 14h | Max: 2h 04m | Hits: 84%/209380See results here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.