Streaming Sortformer release PR04: Adding functional tests for streaming sortformer#14435
Merged
tango4j merged 4 commits intoNVIDIA-NeMo:mainfrom Aug 8, 2025
Merged
Conversation
Signed-off-by: taejinp <[email protected]>
Signed-off-by: taejinp <[email protected]>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds functional tests for the streaming Sortformer speaker diarization model, including both training and inference test scenarios. The purpose is to ensure the streaming Sortformer functionality works correctly in CI environments.
- Adds two functional test scripts for end-to-end streaming speaker diarization testing
- Introduces a new training script specifically for streaming Sortformer diarization
- Provides test coverage for both training and inference workflows
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
tests/functional_tests/L2_Speaker_dev_run_EndtoEnd_Streaming_Speaker_Diarization_Sortformer.sh |
Functional test script for training streaming Sortformer with fast dev run |
tests/functional_tests/L2_Speaker_dev_run_EndtoEnd_Streaming_Diarizer_Inference.sh |
Functional test script for inference using pre-trained streaming Sortformer model |
examples/speaker_tasks/diarization/neural_diarizer/streaming_sortformer_diar_train.py |
Training script for streaming Sortformer diarization model |
examples/speaker_tasks/diarization/neural_diarizer/streaming_sortformer_diar_train.py
Outdated
Show resolved
Hide resolved
Signed-off-by: taejinp <[email protected]>
Signed-off-by: tango4j <[email protected]>
7 tasks
nasretdinovr
pushed a commit
to nasretdinovr/NeMo
that referenced
this pull request
Aug 8, 2025
…ing sortformer (NVIDIA-NeMo#14435) * Adding functional tests for streaming sortformer Signed-off-by: taejinp <[email protected]> * Fixing the unchanged part from offline sortformer Signed-off-by: taejinp <[email protected]> * Fixing lightning imports for seeding Signed-off-by: taejinp <[email protected]> * Apply isort and black reformatting Signed-off-by: tango4j <[email protected]> --------- Signed-off-by: taejinp <[email protected]> Signed-off-by: tango4j <[email protected]> Co-authored-by: tango4j <[email protected]>
guyueh1
pushed a commit
to guyueh1/NeMo
that referenced
this pull request
Aug 25, 2025
…ing sortformer (NVIDIA-NeMo#14435) * Adding functional tests for streaming sortformer Signed-off-by: taejinp <[email protected]> * Fixing the unchanged part from offline sortformer Signed-off-by: taejinp <[email protected]> * Fixing lightning imports for seeding Signed-off-by: taejinp <[email protected]> * Apply isort and black reformatting Signed-off-by: tango4j <[email protected]> --------- Signed-off-by: taejinp <[email protected]> Signed-off-by: tango4j <[email protected]> Co-authored-by: tango4j <[email protected]> Signed-off-by: Guyue Huang <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
This PR is adding functional tests (CI tests) for inference and training.
Collection: [Note which collection this PR will affect]
ASR/speaker_tasks
Add specific line by line info of high level changes in this PR.
Adding these functional tests:
L2_Speaker_dev_run_EndtoEnd_Streaming_Speaker_Diarization_Sortformer.shL2_Speaker_dev_run_EndtoEnd_Streaming_Diarizer_Inference.shAlso adding
streaming_sortformer_train.pyYou can potentially add a usage example below
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in NeMo ASR
Additional Information