Skip to content

Conversation

@tango4j
Copy link
Collaborator

@tango4j tango4j commented Aug 6, 2025

What does this PR do ?

Uploading bugfixes, refactored variables and yamlfile name changes

Collection: [Note which collection this PR will affect]

ASR/speaker_tasks

  • Add specific line by line info of high level changes in this PR.

Adding bugfix, refactored variables and yaml file name fix.

# For evaluation of streaming speaker diarization
python $BASEPATH/neural_diarizer/e2e_diarize_speech.py \
    model_path=/path/to/diar_sortformer_4spk_v1.nemo \
    batch_size=1 \
    dataset_manifest=/path/to/diarization_manifest.json

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • [] Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in NeMo ASR

Additional Information

  • Related to # (issue)

Copy link
Collaborator

@ipmedenn ipmedenn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nithinraok
Copy link
Collaborator

nithinraok commented Aug 6, 2025

Do you have CI-CD run for streaming sortformer inference?

@tango4j tango4j merged commit eed1594 into NVIDIA-NeMo:main Aug 7, 2025
264 of 270 checks passed
@tango4j
Copy link
Collaborator Author

tango4j commented Aug 8, 2025

Do you have CI-CD run for streaming sortformer inference?
@nithinraok
There were some issues so I created a separate PR for functional tests (CI tests)

#14435

nasretdinovr pushed a commit to nasretdinovr/NeMo that referenced this pull request Aug 8, 2025
…iables and yaml file name changes (NVIDIA-NeMo#14416)

* Uploading bugfixes, refactored vars and yamlfile name changes

Signed-off-by: taejinp <[email protected]>

* Adding the missing offline pp yamls

Signed-off-by: taejinp <[email protected]>

---------

Signed-off-by: taejinp <[email protected]>
guyueh1 pushed a commit to guyueh1/NeMo that referenced this pull request Aug 25, 2025
…iables and yaml file name changes (NVIDIA-NeMo#14416)

* Uploading bugfixes, refactored vars and yamlfile name changes

Signed-off-by: taejinp <[email protected]>

* Adding the missing offline pp yamls

Signed-off-by: taejinp <[email protected]>

---------

Signed-off-by: taejinp <[email protected]>
Signed-off-by: Guyue Huang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants