Skip to content

Modified ReferenceField validation to accept instances of ObjectId. #903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
justingiorgi wants to merge 1 commit into from
Closed

Modified ReferenceField validation to accept instances of ObjectId. #903

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions mongoengine/fields.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1002,8 +1002,8 @@ def prepare_query_value(self, op, value):

def validate(self, value):

if not isinstance(value, (self.document_type, DBRef)):
self.error("A ReferenceField only accepts DBRef or documents")
if not isinstance(value, (self.document_type, DBRef, ObjectId)):
self.error("A ReferenceField only accepts DBRef, ObjectId or documents")

if isinstance(value, Document) and value.id is None:
self.error('You can only reference documents once they have been '
Expand Down