Skip to content

Fix to handle Abode server issues #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MisterWil merged 2 commits into from
Jul 26, 2020
Merged

Fix to handle Abode server issues #73

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7af0df2
Fix to handle Abode server issues
shred86 Jul 25, 2020
4926b9b
Remove trailing white space in comment
shred86 Jul 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions abodepy/event_controller.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,11 +192,18 @@ def _on_socket_connected(self):
"""Socket IO connected callback."""
self._connected = True

self._abode.refresh()

for callbacks in self._connection_status_callbacks.items():
for callback in callbacks[1]:
_execute_callback(callback)
try:
self._abode.refresh()
# pylint: disable=W0703
except Exception as exc:
_LOGGER.warning("Captured exception during Abode refresh: %s", exc)
finally:
# Callbacks should still execute even if refresh fails (Abode server
# issues) so that the entity availability in Home Assistant is updated
# since we are in fact connected to the web socket.
for callbacks in self._connection_status_callbacks.items():
for callback in callbacks[1]:
_execute_callback(callback)

def _on_socket_disconnected(self):
"""Socket IO disconnected callback."""
Expand Down