Fix to handle Abode server issues#73
Merged
MisterWil merged 2 commits intoMisterWil:masterfrom Jul 26, 2020
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An issue was identified with the Abode component in Home Assistant where entities are sometimes stuck in an "Unavailable" state after the web socket is disconnected. What appears to be occurring is sometimes the web socket reconnects,
_on_socket_connectedis called which then callsself._abode.refresh(). However, the issue is this refresh will sometimes throw an exception because the response is not correct (Abode server is probably still initializing) which then stops the callbacks from executing. For the Home Assistant Abode component, we still want these callbacks to execute since the web socket is connected.Solution is to execute a try block here and execute the callbacks in the finally section such that they always execute since
self._connectedis in factTrue.