fix(deps): eth-rpc-errors@^4.0.3 -> @metamask/rpc-errors@^6.2.1

[legobeat]

Description

Replace deprecated eth-rpc-errors with @metamask/rpc-errors.

#9253 (comment)

Related issues

• Follow-up to fix(deps): replace eth-json-rpc-errors with eth-rpc-errors #9253

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[leotm]

no more import { ethErrors } from 'eth-rpc-errors' in codebase ✅

do we need to update/test our controller patches @tommasini?

or can they be left alone

[legobeat]

do we need to update/test our controller patches

@metamask/[email protected] supplies its own eth-rpc-errors instance.

I guess this should get resolved by updating the dependency on @metamask/transaction-controller to at least 13.0.0 (2023-09), where it also migrates to @metamask/rpc-errors.

[github-actions]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: af9d846
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/b53d807b-470f-4054-a6dd-ec000af171fa

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
60.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[tommasini]

LGTM! Each controller uses it's version of rpc errors, so I believe this will not impact the controllers, and that will be taken care of when each controller it's updated!

[github-actions]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 3a92d8f
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c255d672-a55c-495d-872b-9878b1bb02ba

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[tommasini]

Before merge please let's wait for the E2E to finish!