Skip to content

fix(deps): eth-rpc-errors@^4.0.3 -> @metamask/rpc-errors@^6.2.1#9255

Closed
legobeat wants to merge 1 commit intoMetaMask:mainfrom
legobeat:deps-eth-rpc-errors
Closed

fix(deps): eth-rpc-errors@^4.0.3 -> @metamask/rpc-errors@^6.2.1#9255
legobeat wants to merge 1 commit intoMetaMask:mainfrom
legobeat:deps-eth-rpc-errors

Conversation

@legobeat
Copy link
Contributor

@legobeat legobeat commented Apr 16, 2024

Description

Replace deprecated eth-rpc-errors with @metamask/rpc-errors.

#9253 (comment)

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@legobeat legobeat added dependencies Pull requests that update a dependency file team-application-security Application security team labels Apr 16, 2024
@legobeat legobeat force-pushed the deps-eth-rpc-errors branch 2 times, most recently from f4592b0 to 6dace74 Compare April 16, 2024 12:18
@legobeat legobeat marked this pull request as ready for review April 16, 2024 12:19
@legobeat legobeat requested a review from a team as a code owner April 16, 2024 12:19
@legobeat legobeat requested a review from a team April 16, 2024 12:19
@legobeat legobeat requested a review from a team as a code owner April 16, 2024 12:19
@legobeat legobeat requested review from Mrtenz and leotm April 16, 2024 12:19
Copy link
Member

@Mrtenz Mrtenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@legobeat legobeat force-pushed the deps-eth-rpc-errors branch from 6dace74 to bda45ed Compare April 16, 2024 21:38
@legobeat
Copy link
Contributor Author

legobeat commented Apr 17, 2024

Closing in favor of identical #9273 to make CI pass without intervention (bitrise integration is broken).

@legobeat legobeat closed this Apr 17, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Apr 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

dependencies Pull requests that update a dependency file team-application-security Application security team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants