Skip to content

fix: migrate from legacy ethjs to @metamask/ethjs#11969

Merged
legobeat merged 3 commits intomainfrom
deps-ethjs-redux
Oct 23, 2024
Merged

fix: migrate from legacy ethjs to @metamask/ethjs#11969
legobeat merged 3 commits intomainfrom
deps-ethjs-redux

Conversation

@legobeat
Copy link
Contributor

@legobeat legobeat commented Oct 23, 2024 •
edited
Loading

Description

  • fix: migrate from legacy ethjs- packages to maintained and already used @metamask/ethjs- forks
    • Removes dependency on deprecated babel-runtime v6
    • Bundle size reduction

Related issues

Blocking

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 23, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@socket-security
Copy link

socket-security bot commented Oct 23, 2024

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

@legobeat legobeat mentioned this pull request Oct 23, 2024
Closed
12 tasks
@legobeat legobeat added dependencies Pull requests that update a dependency file team-application-security Application security team Run Smoke E2E labels Oct 23, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Oct 23, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 88d9746
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d3d6eb6f-22d1-4a53-9f9a-dddfd6135ca4

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 23, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@legobeat legobeat changed the title fix: migrate from legacy ethjs to @metamask/ethjs (redux) fix: migrate from legacy ethjs to @metamask/ethjs Oct 23, 2024
@legobeat legobeat marked this pull request as ready for review October 23, 2024 09:49
@legobeat legobeat requested a review from a team as a code owner October 23, 2024 09:49
@legobeat legobeat requested a review from a team October 23, 2024 09:49
@legobeat legobeat requested review from a team as code owners October 23, 2024 09:49
@legobeat legobeat added this pull request to the merge queue Oct 23, 2024
Merged via the queue into main with commit 8229dbc Oct 23, 2024
@legobeat legobeat deleted the deps-ethjs-redux branch October 23, 2024 11:31
@github-actions github-actions bot locked and limited conversation to collaborators Oct 23, 2024
@metamaskbot metamaskbot added the release-7.35.0 Issue or pull request that will be included in release 7.35.0 label Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@tommasini tommasini tommasini approved these changes

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file release-7.35.0 Issue or pull request that will be included in release 7.35.0 team-application-security Application security team team-lavamoat

Projects

PR review queue
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@legobeat @tommasini @metamaskbot