Enable arrow-parens ESLint rule#8056
Merged
jennypollack merged 1 commit intoMetaMask:developfrom Feb 17, 2020
Merged
Conversation
whymarrh
requested review from
Gudahtt,
danjm,
jennypollack and
rekmarks
as code owners
jennypollack
approved these changes
Feb 17, 2020
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 5, 2025
#30661) ## **Description** @davidmurdoch requested this feature here: #30440 (review) Also adds to the VSCode GitLens settings. If a Cursor user could help with the Cursor settings, that would be much appreciated. We should discuss: - The inclusion of #17092, as I'm undecided about it - Whether it's appropriate to automatically execute `git config blame.ignoreRevsFile .git-blame-ignore-revs` in `postinstall`. It writes to the local `.git/config` file in your `metamask-extension` folder, so it's only changing that one folder. Command to get commits with over 200 file changes ``` git log --pretty=format:"%H %s" --shortstat | awk '{if ($1 ~ /^[0-9]+$/) {num = $1 + 0; if (num > 200 && current_hash !~ /Revert/) print num " " current_hash} else current_hash = $0}' | sort -nr ``` [](https://codespaces.new/MetaMask/metamask-extension/pull/30661?quickstart=1) ## **Related issues** David Murdoch request: #30440 (review) ## **Ignored PRs** - #6304 - #7730 - #8023 - #8056 - #8595 - #9239 - #9274 - #10358 - #10655 - #10911 - #17092 - #22639 - #22531 - #30440 <!--## **Manual testing steps** ## **Screenshots/Recordings** ## **Pre-merge author checklist** ## **Pre-merge reviewer checklist**--> --------- Co-authored-by: David Murdoch <187813+davidmurdoch@users.noreply.github.com>
](https://codespaces.new/MetaMask/metamask-extension/pull/30661?quickstart=1){kind=link}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables the core ESLint
arrow-parensrule, which enforces parentheses around arrow function parameters regardless of arity.[1]This will allow introduces type annotations where needed with less noise.