Confirmations code re-structuring by jpuri · Pull Request #22639 · MetaMask/metamask-extension

jpuri · 2024-01-23T15:26:32Z

Description

Restructuring Confirmations related code under confirmations domain.

Related issues

Fixes: MetaMask/MetaMask-planning#1862

Manual testing steps

NA

Screenshots/Recordings

NA

Pre-merge author checklist

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-01-23T15:26:45Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

…amask-extension into confirmations_restructuring

… confirmations_restructuring

metamaskbot · 2024-02-06T11:32:14Z

Builds ready [fdff2a6]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5, 6, 7
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (824 ± 29 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	92	140	111	12	6
		domContentLoaded	9	30	15	6	3
		load	733	946	824	60	29
		domInteractive	9	30	15	6	3

Bundle size diffs [🚀 Bundle size reduced!]

background: -6 Bytes (-0.00%)
ui: 21.05 KiB (0.30%)
common: 0 Bytes (0.00%)

.circleci/config.yml

… confirmations_restructuring

metamaskbot · 2024-02-07T06:19:42Z

Builds ready [59f9811]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5, 6, 7
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (809 ± 32 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	80	149	101	15	7
		domContentLoaded	9	49	16	8	4
		load	711	1002	809	68	32
		domInteractive	9	49	16	8	4

Bundle size diffs [🚀 Bundle size reduced!]

background: -6 Bytes (-0.00%)
ui: 21.09 KiB (0.30%)
common: 0 Bytes (0.00%)

metamaskbot · 2024-02-07T12:50:29Z

Builds ready [0b1459d]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5, 6, 7
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (830 ± 28 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	80	134	109	17	8
		domContentLoaded	9	39	17	7	3
		load	757	952	830	57	28
		domInteractive	9	39	17	7	3

Bundle size diffs [🚀 Bundle size reduced!]

background: -6 Bytes (-0.00%)
ui: 21.09 KiB (0.30%)
common: 0 Bytes (0.00%)

ui/pages/confirmations/components/confirm-page-container/index.scss

metamaskbot · 2024-02-07T16:00:43Z

Builds ready [6f6b9cf]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5, 6, 7
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (821 ± 23 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	85	163	117	20	10
		domContentLoaded	9	53	21	12	6
		load	752	927	821	48	23
		domInteractive	9	53	21	12	6

Bundle size diffs [🚀 Bundle size reduced!]

background: -6 Bytes (-0.00%)
ui: 21.09 KiB (0.30%)
common: 0 Bytes (0.00%)

ui/components/app/app-components.scss

hmalik88

LGTM

Confirmations code re-structuring

3007a8e

jpuri added 11 commits January 23, 2024 20:57

Merge branch 'develop' into confirmations_restructuring

920d62e

UPdates

4474143

Merge branch 'confirmations_restructuring' of github.com:MetaMask/met…

fac4a9e

…amask-extension into confirmations_restructuring

Update

b6052be

Merge

f0ffcd3

Update

e964f08

Update

add2ed1

Merge branch 'develop' of github.com:MetaMask/metamask-extension into…

0e8cf82

… confirmations_restructuring

Update

39c6ff4

Update

8ed7a42

Update

4b05d30

jpuri added team-confirmations-secure-ux-PR PRs from the confirmations team needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Jan 30, 2024

jpuri added 3 commits January 30, 2024 16:34

Update

3b2aedd

Merge branch 'develop' into confirmations_restructuring

8299c2f

Update

9684438

jpuri marked this pull request as ready for review January 30, 2024 11:12

jpuri requested review from a team as code owners January 30, 2024 11:12

jpuri added 9 commits January 30, 2024 16:43

Update

d8a94f5

Update

831a1d1

Update

4b0460f

Update

138e0e2

Update

857f903

Update

a3ea98a

Update

14efe21

Update

ba806e5

Update

e031787

jpuri added 2 commits February 6, 2024 16:26

Fix lint

f0bcd16

update

fdff2a6

jpuri requested review from digiwand and segun February 6, 2024 12:58

digiwand reviewed Feb 6, 2024

View reviewed changes

.circleci/config.yml Show resolved Hide resolved

digiwand previously approved these changes Feb 6, 2024

View reviewed changes

blackdevelopa previously approved these changes Feb 6, 2024

View reviewed changes

Merge branch 'develop' of github.com:MetaMask/metamask-extension into…

0812847

… confirmations_restructuring

jpuri dismissed stale reviews from blackdevelopa and digiwand via 0812847 February 7, 2024 05:41

Build fix

59f9811

digiwand previously approved these changes Feb 7, 2024

View reviewed changes

merge

0b1459d

jpuri dismissed digiwand’s stale review via 0b1459d February 7, 2024 12:24

jpuri requested review from blackdevelopa and digiwand February 7, 2024 12:28

merge

6f6b9cf

hmalik88 reviewed Feb 7, 2024

View reviewed changes

ui/pages/confirmations/components/confirm-page-container/index.scss Show resolved Hide resolved

hmalik88 reviewed Feb 7, 2024

View reviewed changes

ui/components/app/app-components.scss Show resolved Hide resolved

hmalik88 approved these changes Feb 7, 2024

View reviewed changes

blackdevelopa approved these changes Feb 7, 2024

View reviewed changes

jpuri merged commit c4c12ec into develop Feb 7, 2024

jpuri deleted the confirmations_restructuring branch February 7, 2024 23:52

github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Feb 7, 2024

github-actions bot locked and limited conversation to collaborators Feb 7, 2024

metamaskbot added the release-11.11.0 Issue or pull request that will be included in release 11.11.0 label Feb 7, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Confirmations code re-structuring#22639

Confirmations code re-structuring#22639
jpuri merged 41 commits intodevelopfrom
confirmations_restructuring

jpuri commented Jan 23, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Jan 23, 2024

Uh oh!

metamaskbot commented Feb 6, 2024

Uh oh!

Uh oh!

metamaskbot commented Feb 7, 2024

Uh oh!

metamaskbot commented Feb 7, 2024

Uh oh!

Uh oh!

metamaskbot commented Feb 7, 2024

Uh oh!

Uh oh!

hmalik88 left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

jpuri commented Jan 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related issues

Manual testing steps

Screenshots/Recordings

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Jan 23, 2024

Uh oh!

metamaskbot commented Feb 6, 2024

Uh oh!

Uh oh!

metamaskbot commented Feb 7, 2024

Uh oh!

metamaskbot commented Feb 7, 2024

Uh oh!

Uh oh!

metamaskbot commented Feb 7, 2024

Uh oh!

Uh oh!

hmalik88 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

jpuri commented Jan 23, 2024 •

edited

Loading