Conversation
| for (const key in this.config) { | ||
| flatState = { ...flatState, ...this.config[key].getState() } | ||
| const controller = this.config[key] | ||
| const state = controller.getState ? controller.getState() : controller.state |
There was a problem hiding this comment.
This is a temporary patch to ComposableObservableStore to provide GABA API compatibility. Once we're fully on GABA, this entire module goes away and we'll be using gaba/ComposableController instead.
There was a problem hiding this comment.
Can we add a comment here outlining the two cases we're handling and noting the conditions under which we'd remove this logic?
bitpshr
force-pushed
the
gaba-currencyratecontroller
branch
2 times, most recently
from
ef32ea7 to
6038879
Compare
app/scripts/lib/getObjStructure.js
Outdated
There was a problem hiding this comment.
I assume this is part of a global search and replace, but in that case shouldn't be CurrencyRateController, without the s ?
There was a problem hiding this comment.
Great catch, this was a manual update. Fixed.
bitpshr
force-pushed
the
gaba-currencyratecontroller
branch
from
6038879 to
ec8285d
Compare
| for (const key in this.config) { | ||
| flatState = { ...flatState, ...this.config[key].getState() } | ||
| const controller = this.config[key] | ||
| const state = controller.getState ? controller.getState() : controller.state |
There was a problem hiding this comment.
Can we add a comment here outlining the two cases we're handling and noting the conditions under which we'd remove this logic?
| @@ -0,0 +1,22 @@ | |||
| const clone = require('clone') | |||
|
|
|||
| const version = 30 | |||
whymarrh
left a comment
whymarrh
left a comment
There was a problem hiding this comment.
Two small things:
- I think we should pin the version of GABA we're pulling in
- Can we add a few quick tests for the migration we're introducing?
| "fast-levenshtein": "^2.0.6", | ||
| "file-loader": "^1.1.11", | ||
| "fuse.js": "^3.2.0", | ||
| "gaba": "^1.0.0-beta.45", |
There was a problem hiding this comment.
We should pin this exactly so that we're not automatically pulling in new prereleases
|
I'm closing this for now as this will require some work to update (might be worth creating a new PR) |
5 participants
This pull request adds
gaba/CurrencyRateControllerto the extension.