Save recent network balances in local storage#5843
Merged
Conversation
danjm
force-pushed
the
cache-network-balances-local-storage
branch
3 times, most recently
from
d82e5a8 to
929bd56
Compare
Collaborator
danjm
force-pushed
the
cache-network-balances-local-storage
branch
from
929bd56 to
6b0500b
Compare
danjm
force-pushed
the
cache-network-balances-local-storage
branch
from
6b0500b to
cf2db0f
Compare
danjm
force-pushed
the
cache-network-balances-local-storage
branch
from
cf2db0f to
f4cc41c
Compare
Collaborator
danjm
force-pushed
the
cache-network-balances-local-storage
branch
from
f4cc41c to
cd179e8
Compare
danjm
force-pushed
the
cache-network-balances-local-storage
branch
from
cd179e8 to
efa04db
Compare
Collaborator
whymarrh
suggested changes
Nov 30, 2018
Contributor
whymarrh
left a comment
whymarrh
left a comment
There was a problem hiding this comment.
A few quick suggestions/comments
ui/app/components/pages/create-account/connect-hardware/index.js
Outdated
Show resolved
Hide resolved
Co-Authored-By: danjm <[email protected]>
Collaborator
whymarrh
approved these changes
Nov 30, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR prevents errors caused by
nullaccount balances. This problem is described in detail #5842While we need to resolve the root cause of that as soon as possible, this PR provides a front end band-aid by saving the most non-null balance for each account in local storage. If the account balance is null when we select it from state, we will instead return the most recent cached value.
These null returns are very inconsistent and almost never happen two blocks in a row, so the account balance will (almost always) be at most one block out of date.