-
-
Notifications
You must be signed in to change notification settings - Fork 255
Release 697.0.0 #7253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 697.0.0 #7253
Conversation
|
@metamaskbot publish-preview |
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
|
|
||
| ### Changed | ||
|
|
||
| - **BREAKING:** Bump `@metamask/assets-controllers` from `^91.0.0` to `^92.0.0` ([#7253](https://github.com/MetaMask/core/pull/7253)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@salimtb do we need to release this package too ? I see CI working fine in your client updates maybe this is not needed ? Nothing would break if we don't upgrade TransactionPayController too ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cryptodev-2s not sure we have to release it , since assets is not a peer dependency anymore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@salimtb but won't this assets controllers update break older versions of the TransactionPayController, since they won't use the correct version of AuthenticationController:getBearerToken?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The TransactionPayController doesn't do any remote requests through the asset controller, only reliant on state. So ideally no breaking changes needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we consider this not breaking as the TransactionPayController is not reliant on any API requests and it should only validate that messenger action is included if called?
With this new dependency model, can we consider it on a per controller basis, rather than assuming every major is a breaking, is that not the key benefit?
cryptodev-2s
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
|
||
| ### Changed | ||
|
|
||
| - **BREAKING:** Bump `@metamask/assets-controllers` from `^91.0.0` to `^92.0.0` ([#7253](https://github.com/MetaMask/core/pull/7253)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we consider this not breaking as the TransactionPayController is not reliant on any API requests and it should only validate that messenger action is included if called?
With this new dependency model, can we consider it on a per controller basis, rather than assuming every major is a breaking, is that not the key benefit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally no breaking change in TransactionPayController, but unblocking as going AFK.
d89e71d
Gudahtt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Explanation
extension PR: MetaMask/metamask-extension#38359
Mobile PR: MetaMask/metamask-mobile#23367
References
Checklist
Note
Releases 697.0.0, publishing @metamask/assets-controllers 92.0.0 and updating dependent packages (bridge/transaction-pay), plus a chain ID fix in bridge-controller.
697.0.0.@metamask/[email protected]searchTokens.@metamask/bridge-controller@metamask/assets-controllersto^92.0.0.@metamask/transaction-pay-controller@metamask/assets-controllersto^92.0.0,@metamask/bridge-controllerto^63.2.0,@metamask/bridge-status-controllerto^63.1.0,@metamask/transaction-controllerto^62.3.0.yarn.lockaccordingly.Written by Cursor Bugbot for commit d89e71d. This will update automatically on new commits. Configure here.