Skip to content

Conversation

@salimtb
Copy link
Contributor

@salimtb salimtb commented Nov 27, 2025

Explanation

extension PR: MetaMask/metamask-extension#38359
Mobile PR: MetaMask/metamask-mobile#23367

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Note

Releases 697.0.0, publishing @metamask/assets-controllers 92.0.0 and updating dependent packages (bridge/transaction-pay), plus a chain ID fix in bridge-controller.

  • Release
    • Bump monorepo version to 697.0.0.
  • Packages
    • @metamask/[email protected]
      • Changelog: optional JWT auth for multi‑chain accounts API; optional market data in searchTokens.
    • @metamask/bridge-controller
      • Dependency: bump @metamask/assets-controllers to ^92.0.0.
      • Fix: add missing MON and SEI to integer chain IDs.
    • @metamask/transaction-pay-controller
      • Dependencies: bump @metamask/assets-controllers to ^92.0.0, @metamask/bridge-controller to ^63.2.0, @metamask/bridge-status-controller to ^63.1.0, @metamask/transaction-controller to ^62.3.0.
  • Dependencies
    • Update yarn.lock accordingly.

Written by Cursor Bugbot for commit d89e71d. This will update automatically on new commits. Configure here.

@salimtb
Copy link
Contributor Author

salimtb commented Nov 27, 2025

@metamaskbot publish-preview

@salimtb salimtb marked this pull request as ready for review November 27, 2025 13:58
@salimtb salimtb requested review from a team as code owners November 27, 2025 13:58
@FrederikBolding FrederikBolding changed the title Update Release 697.0.0 Release 697.0.0 Nov 27, 2025
@github-actions

This comment has been minimized.

1 similar comment
@github-actions

This comment has been minimized.


### Changed

- **BREAKING:** Bump `@metamask/assets-controllers` from `^91.0.0` to `^92.0.0` ([#7253](https://github.com/MetaMask/core/pull/7253))
Copy link
Contributor

@cryptodev-2s cryptodev-2s Nov 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@salimtb do we need to release this package too ? I see CI working fine in your client updates maybe this is not needed ? Nothing would break if we don't upgrade TransactionPayController too ?

Copy link
Contributor Author

@salimtb salimtb Nov 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cryptodev-2s not sure we have to release it , since assets is not a peer dependency anymore

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@salimtb but won't this assets controllers update break older versions of the TransactionPayController, since they won't use the correct version of AuthenticationController:getBearerToken?

Copy link
Member

@matthewwalsh0 matthewwalsh0 Nov 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The TransactionPayController doesn't do any remote requests through the asset controller, only reliant on state. So ideally no breaking changes needed.

Copy link
Member

@matthewwalsh0 matthewwalsh0 Nov 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we consider this not breaking as the TransactionPayController is not reliant on any API requests and it should only validate that messenger action is included if called?

With this new dependency model, can we consider it on a per controller basis, rather than assuming every major is a breaking, is that not the key benefit?

cryptodev-2s
cryptodev-2s previously approved these changes Nov 27, 2025
Copy link
Contributor

@cryptodev-2s cryptodev-2s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!


### Changed

- **BREAKING:** Bump `@metamask/assets-controllers` from `^91.0.0` to `^92.0.0` ([#7253](https://github.com/MetaMask/core/pull/7253))
Copy link
Member

@matthewwalsh0 matthewwalsh0 Nov 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we consider this not breaking as the TransactionPayController is not reliant on any API requests and it should only validate that messenger action is included if called?

With this new dependency model, can we consider it on a per controller basis, rather than assuming every major is a breaking, is that not the key benefit?

matthewwalsh0
matthewwalsh0 previously approved these changes Nov 27, 2025
Copy link
Member

@matthewwalsh0 matthewwalsh0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally no breaking change in TransactionPayController, but unblocking as going AFK.

@salimtb salimtb dismissed stale reviews from matthewwalsh0 and cryptodev-2s via d89e71d November 27, 2025 16:21
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@matthewwalsh0 matthewwalsh0 added this pull request to the merge queue Nov 27, 2025
Merged via the queue into main with commit 9e773c7 Nov 27, 2025
277 checks passed
@matthewwalsh0 matthewwalsh0 deleted the release/697.0.0 branch November 27, 2025 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants