Skip to content

Conversation

@salimtb
Copy link
Contributor

@salimtb salimtb commented Nov 27, 2025

Description

bump assets controllers to v92

Open in GitHub Codespaces

Changelog

CHANGELOG entry: bump assets controllers to v92

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Bumps @metamask/assets-controllers to v92, updates Codefi token prices service and controller messengers (adds bearer-token action), and adjusts init typings and LavaMoat policies.

  • Dependencies
    • Bump @metamask/assets-controllers to v92 (patch updated), cascading yarn.lock updates for related MetaMask packages.
  • Token Prices Service (dist/token-prices-service/codefi-v2.*)
    • Add currency mon to SUPPORTED_CURRENCIES.
    • Update SPOT_PRICES_SUPPORT_INFO mappings (many set to null).
    • Build spot-prices URL using decimal chain ID: parseInt(chainId, 16).
  • Controller Messengers
    • token-balances and token-detection messengers: allow AuthenticationController:getBearerToken action.
  • Controller Init adjustments
    • AccountTrackerController, AssetsContractController, CurrencyRateController, TokenListController, TokensController: pass messenger despite type/version mismatches (annotated with @ts-expect-error); use getGlobalChainId where applicable.
  • LavaMoat policies
    • Reference @metamask/assets-controllers>@metamask/phishing-controller instead of direct @metamask/phishing-controller and add its policy block.

Written by Cursor Bugbot for commit 0269912. This will update automatically on new commits. Configure here.

@salimtb salimtb mentioned this pull request Nov 27, 2025
4 tasks
github-merge-queue bot pushed a commit to MetaMask/core that referenced this pull request Nov 27, 2025
## Explanation

extension PR: MetaMask/metamask-extension#38359
Mobile PR: MetaMask/metamask-mobile#23367

<!--
Thanks for your contribution! Take a moment to answer these questions so
that reviewers have the information they need to properly understand
your changes:

* What is the current state of things and why does it need to change?
* What is the solution your changes offer and how does it work?
* Are there any changes whose purpose might not obvious to those
unfamiliar with the domain?
* If your primary goal was to update one package but you found you had
to update another one along the way, why did you do so?
* If you had to upgrade a dependency, why did you do so?
-->

## References

<!--
Are there any issues that this pull request is tied to?
Are there other links that reviewers should consult to understand these
changes better?
Are there client or consumer pull requests to adopt any breaking
changes?

For example:

* Fixes #12345
* Related to #67890
-->

## Checklist

- [ ] I've updated the test suite for new or updated code as appropriate
- [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or
updated code as appropriate
- [ ] I've communicated my changes to consumers by [updating changelogs
for packages I've
changed](https://github.com/MetaMask/core/tree/main/docs/contributing.md#updating-changelogs)
- [ ] I've introduced [breaking
changes](https://github.com/MetaMask/core/tree/main/docs/breaking-changes.md)
in this PR and have prepared draft pull requests for clients and
consumer packages to resolve them


<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> Releases 697.0.0, publishing @metamask/assets-controllers 92.0.0 and
updating dependent packages (bridge/transaction-pay), plus a chain ID
fix in bridge-controller.
> 
> - **Release**
>   - Bump monorepo version to `697.0.0`.
> - **Packages**
>   - **`@metamask/[email protected]`**
> - Changelog: optional JWT auth for multi‑chain accounts API; optional
market data in `searchTokens`.
>   - **`@metamask/bridge-controller`**
>     - Dependency: bump `@metamask/assets-controllers` to `^92.0.0`.
>     - Fix: add missing MON and SEI to integer chain IDs.
>   - **`@metamask/transaction-pay-controller`**
> - Dependencies: bump `@metamask/assets-controllers` to `^92.0.0`,
`@metamask/bridge-controller` to `^63.2.0`,
`@metamask/bridge-status-controller` to `^63.1.0`,
`@metamask/transaction-controller` to `^62.3.0`.
> - **Dependencies**
>   - Update `yarn.lock` accordingly.
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
d89e71d. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@socket-security
Copy link

socket-security bot commented Nov 28, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updated@​metamask/​assets-controllers@​91.0.0 ⏵ 92.0.096 -110091 +198100

View full report

@salimtb salimtb changed the title chore: bump assets package chore: bump assets package to v92 Nov 28, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [c8ff60e]
📊 Page Load Benchmark Results

Current Commit: c8ff60e | Date: 11/28/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.04s (±65ms) 🟡 | historical mean value: 1.05s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 727ms (±61ms) 🟢 | historical mean value: 727ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 76ms (±9ms) 🟢 | historical mean value: 78ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.04s 65ms 1.01s 1.33s 1.25s 1.33s
domContentLoaded 727ms 61ms 698ms 1.01s 930ms 1.01s
firstPaint 76ms 9ms 60ms 148ms 84ms 148ms
firstContentfulPaint 76ms 9ms 60ms 148ms 84ms 148ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: -58 Bytes (0%)
  • ui: 9 Bytes (0%)
  • common: 34.48 KiB (0.39%)

@metamaskbot
Copy link
Collaborator

Builds ready [c8ff60e]
📊 Page Load Benchmark Results

Current Commit: c8ff60e | Date: 11/28/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.04s (±65ms) 🟡 | historical mean value: 1.05s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 727ms (±61ms) 🟢 | historical mean value: 728ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 76ms (±9ms) 🟢 | historical mean value: 78ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.04s 65ms 1.01s 1.33s 1.25s 1.33s
domContentLoaded 727ms 61ms 698ms 1.01s 930ms 1.01s
firstPaint 76ms 9ms 60ms 148ms 84ms 148ms
firstContentfulPaint 76ms 9ms 60ms 148ms 84ms 148ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: -58 Bytes (0%)
  • ui: 9 Bytes (0%)
  • common: 34.48 KiB (0.39%)

@salimtb
Copy link
Contributor Author

salimtb commented Nov 28, 2025

@metamaskbot update-policies

@metamaskbot
Copy link
Collaborator

Builds ready [08b0cbf]
📊 Page Load Benchmark Results

Current Commit: 08b0cbf | Date: 11/28/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.06s (±66ms) 🟡 | historical mean value: 1.05s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 743ms (±64ms) 🟢 | historical mean value: 728ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 79ms (±9ms) 🟢 | historical mean value: 78ms ⬆️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.06s 66ms 1.02s 1.37s 1.26s 1.37s
domContentLoaded 743ms 64ms 711ms 1.04s 944ms 1.04s
firstPaint 79ms 9ms 64ms 156ms 88ms 156ms
firstContentfulPaint 79ms 9ms 64ms 156ms 88ms 156ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: -58 Bytes (0%)
  • ui: 9 Bytes (0%)
  • common: 34.48 KiB (0.39%)

@metamaskbot
Copy link
Collaborator

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

@metamaskbot
Copy link
Collaborator

✨ Files requiring CODEOWNER review ✨

🧩 @MetaMask/extension-devs (5 files, +73 -5)
  • 📁 lavamoat/
    • 📁 browserify/
      • 📁 beta/
        • 📄 policy.json +18 -1
      • 📁 experimental/
        • 📄 policy.json +18 -1
      • 📁 flask/
        • 📄 policy.json +18 -1
      • 📁 main/
        • 📄 policy.json +18 -1
    • 📁 webpack/
      • 📁 mv2/
        • 📄 policy.json +1 -1

📜 @MetaMask/policy-reviewers (5 files, +73 -5)
  • 📁 lavamoat/
    • 📁 browserify/
      • 📁 beta/
        • 📄 policy.json +18 -1
      • 📁 experimental/
        • 📄 policy.json +18 -1
      • 📁 flask/
        • 📄 policy.json +18 -1
      • 📁 main/
        • 📄 policy.json +18 -1
    • 📁 webpack/
      • 📁 mv2/
        • 📄 policy.json +1 -1

Tip

Follow the policy review process outlined in the LavaMoat Policy Review Process doc before expecting an approval from Policy Reviewers.


🔗 @MetaMask/supply-chain (5 files, +73 -5)
  • 📁 lavamoat/
    • 📁 browserify/
      • 📁 beta/
        • 📄 policy.json +18 -1
      • 📁 experimental/
        • 📄 policy.json +18 -1
      • 📁 flask/
        • 📄 policy.json +18 -1
      • 📁 main/
        • 📄 policy.json +18 -1
    • 📁 webpack/
      • 📁 mv2/
        • 📄 policy.json +1 -1

@metamaskbot
Copy link
Collaborator

Builds ready [0269912]
UI Startup Metrics (1193 ± 95 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup1193100415429512541399
load100285712998510471161
domContentLoaded99685412948410411152
domInteractive251599202185
firstPaint5479013173899791104
backgroundConnect20919125211213231
firstReactRender302065103352
getState35161412337105
initialActions103112
loadScripts793660106783839948
setupStore1063641117
numNetworkReqs1257619570
BrowserifyPower User HomeuiStartup20651786266118821532458
load1025896145911610341342
domContentLoaded1011889145011810151325
domInteractive3518155243497
firstPaint5309614073919841334
backgroundConnect258205760104233531
firstReactRender6140121186399
getState19313071177205249
initialActions106113
loadScripts80168812361158021113
setupStore22992112545
numNetworkReqs1146528850133218
WebpackStandard HomeuiStartup8266981200908611000
load64056492873667793
domContentLoaded63556192073663787
domInteractive2716132242194
firstPaint22575794146202597
backgroundConnect11586101027
firstReactRender27194663239
getState25135093341
initialActions103112
loadScripts63255991271660778
setupStore1062541219
numNetworkReqs1257519569
WebpackPower User HomeuiStartup15931266216121416822002
load681591109697690934
domContentLoaded670583108598674925
domInteractive36171753033119
firstPaint295971093192321686
backgroundConnect68864715220540
firstReactRender57458676269
getState195131706100191314
initialActions105112
loadScripts667581107696672923
setupStore211059112550
numNetworkReqs1586630261217281
FirefoxBrowserifyStandard HomeuiStartup12271064180812512781458
load101289112897910631176
domContentLoaded101289012888010631175
domInteractive5331130237592
firstPaint------
backgroundConnect3721317323862
firstReactRender22175162335
getState13688121134
initialActions103112
loadScripts99187412637610451147
setupStore145196261025
numNetworkReqs1256816662
BrowserifyPower User HomeuiStartup27011772495460227874183
load12081003260221012621579
domContentLoaded12081003260221012621578
domInteractive13335515117130453
firstPaint------
backgroundConnect139381183182117516
firstReactRender61391502261116
getState25165894198242740
initialActions2132323
loadScripts1163982161215312221517
setupStore1657799205166660
numNetworkReqs90613104582218
WebpackStandard HomeuiStartup14831260194215315691811
load12381074156411113061474
domContentLoaded12381074156411113061473
domInteractive55271633278110
firstPaint------
backgroundConnect46201652644111
firstReactRender27217582741
getState136207201323
initialActions102112
loadScripts12131059154110512811423
setupStore146113161356
numNetworkReqs1256917664
WebpackPower User HomeuiStartup30212230518876829435066
load15021176343745015052764
domContentLoaded15021175343745015052763
domInteractive11929500107103414
firstPaint------
backgroundConnect183301285243147814
firstReactRender65392873164119
getState302381882294404894
initialActions216123
loadScripts14261156341636014802482
setupStore1407707167143638
numNetworkReqs906026137101168
📊 Page Load Benchmark Results

Current Commit: 0269912 | Date: 11/28/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.06s (±115ms) 🟡 | historical mean value: 1.04s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 742ms (±142ms) 🟢 | historical mean value: 726ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 89ms (±122ms) 🟢 | historical mean value: 78ms ⬆️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.06s 115ms 1.02s 2.17s 1.07s 2.17s
domContentLoaded 742ms 142ms 704ms 2.13s 748ms 2.13s
firstPaint 89ms 122ms 60ms 1.30s 88ms 1.30s
firstContentfulPaint 89ms 122ms 60ms 1.30s 88ms 1.30s
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 170 Bytes (0%)
  • ui: 3.05 KiB (0.04%)
  • common: 35.13 KiB (0.4%)

@salimtb salimtb marked this pull request as ready for review November 28, 2025 15:24
@salimtb salimtb requested review from a team as code owners November 28, 2025 15:24
"punycode": true
}
},
"@metamask/assets-controllers>@metamask/phishing-controller": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

expected, we are adding this controller in this new version.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assets controller package is quite large, we're planning out epics to split this up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants