-
Notifications
You must be signed in to change notification settings - Fork 5.4k
chore: bump assets package to v92 #38359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
## Explanation extension PR: MetaMask/metamask-extension#38359 Mobile PR: MetaMask/metamask-mobile#23367 <!-- Thanks for your contribution! Take a moment to answer these questions so that reviewers have the information they need to properly understand your changes: * What is the current state of things and why does it need to change? * What is the solution your changes offer and how does it work? * Are there any changes whose purpose might not obvious to those unfamiliar with the domain? * If your primary goal was to update one package but you found you had to update another one along the way, why did you do so? * If you had to upgrade a dependency, why did you do so? --> ## References <!-- Are there any issues that this pull request is tied to? Are there other links that reviewers should consult to understand these changes better? Are there client or consumer pull requests to adopt any breaking changes? For example: * Fixes #12345 * Related to #67890 --> ## Checklist - [ ] I've updated the test suite for new or updated code as appropriate - [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [ ] I've communicated my changes to consumers by [updating changelogs for packages I've changed](https://github.com/MetaMask/core/tree/main/docs/contributing.md#updating-changelogs) - [ ] I've introduced [breaking changes](https://github.com/MetaMask/core/tree/main/docs/breaking-changes.md) in this PR and have prepared draft pull requests for clients and consumer packages to resolve them <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Releases 697.0.0, publishing @metamask/assets-controllers 92.0.0 and updating dependent packages (bridge/transaction-pay), plus a chain ID fix in bridge-controller. > > - **Release** > - Bump monorepo version to `697.0.0`. > - **Packages** > - **`@metamask/[email protected]`** > - Changelog: optional JWT auth for multi‑chain accounts API; optional market data in `searchTokens`. > - **`@metamask/bridge-controller`** > - Dependency: bump `@metamask/assets-controllers` to `^92.0.0`. > - Fix: add missing MON and SEI to integer chain IDs. > - **`@metamask/transaction-pay-controller`** > - Dependencies: bump `@metamask/assets-controllers` to `^92.0.0`, `@metamask/bridge-controller` to `^63.2.0`, `@metamask/bridge-status-controller` to `^63.1.0`, `@metamask/transaction-controller` to `^62.3.0`. > - **Dependencies** > - Update `yarn.lock` accordingly. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit d89e71d. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Builds ready [c8ff60e]
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [c8ff60e]
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
|
@metamaskbot update-policies |
Builds ready [08b0cbf]
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
|
Policies updated. 🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff |
✨ Files requiring CODEOWNER review ✨🧩 @MetaMask/extension-devs (5 files, +73 -5)
📜 @MetaMask/policy-reviewers (5 files, +73 -5)
Tip Follow the policy review process outlined in the LavaMoat Policy Review Process doc before expecting an approval from Policy Reviewers. 🔗 @MetaMask/supply-chain (5 files, +73 -5)
|
Builds ready [0269912]
UI Startup Metrics (1193 ± 95 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
| "punycode": true | ||
| } | ||
| }, | ||
| "@metamask/assets-controllers>@metamask/phishing-controller": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
expected, we are adding this controller in this new version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
assets controller package is quite large, we're planning out epics to split this up.
Description
bump assets controllers to v92
Changelog
CHANGELOG entry: bump assets controllers to v92
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Bumps
@metamask/assets-controllersto v92, updates Codefi token prices service and controller messengers (adds bearer-token action), and adjusts init typings and LavaMoat policies.@metamask/assets-controllerstov92(patch updated), cascading yarn.lock updates for related MetaMask packages.dist/token-prices-service/codefi-v2.*)montoSUPPORTED_CURRENCIES.SPOT_PRICES_SUPPORT_INFOmappings (many set tonull).parseInt(chainId, 16).token-balancesandtoken-detectionmessengers: allowAuthenticationController:getBearerTokenaction.AccountTrackerController,AssetsContractController,CurrencyRateController,TokenListController,TokensController: passmessengerdespite type/version mismatches (annotated with@ts-expect-error); usegetGlobalChainIdwhere applicable.@metamask/assets-controllers>@metamask/phishing-controllerinstead of direct@metamask/phishing-controllerand add its policy block.Written by Cursor Bugbot for commit 0269912. This will update automatically on new commits. Configure here.