-
-
Notifications
You must be signed in to change notification settings - Fork 19.7k
Enabled 2 mesh viewers #26181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
thinkyhead
merged 93 commits into
MarlinFirmware:bugfix-2.1.x
from
classicrocker883:bugfix-2.1.x-redo
Mar 20, 2025
Merged
Enabled 2 mesh viewers #26181
Changes from 16 commits
Commits
Show all changes
93 commits
Select commit
Hold shift + click to select a range
47bfe07
fix gcode preview
classicrocker883 8c2f232
add 2nd mesh viewer option
classicrocker883 8a67bfc
add missing env to pins.h (CREALITY_V4)
classicrocker883 c725f0e
optimize cardreader.h - OPTARG
classicrocker883 1929c2e
Merge branch 'bugfix-2.1.x' of https://github.com/MarlinFirmware/Marl…
classicrocker883 884027a
Update Conditionals_post.h
classicrocker883 c94f04b
use has_mesh
thinkyhead aece6f5
translatable
thinkyhead 77fdb58
format
thinkyhead 699c598
Mesh without mesh viewer
thinkyhead 270122e
tweak drawing
thinkyhead e813b70
tweak alert print
thinkyhead 5a5f4bd
viewer_asymmetric_range still referenced
thinkyhead a882d17
better for intellisense
thinkyhead dc9ac72
optional level
thinkyhead e00b3e5
tweak print
thinkyhead 6cc92cc
cleanup
thinkyhead bcba732
no more viewer_asymmetric_range ?
thinkyhead 77ccf54
string update
thinkyhead e9f7742
misc. cleanup
thinkyhead e22e9cc
revert gcode_preview.cpp
classicrocker883 bbc91e0
revert gcode_preview.cpp
classicrocker883 6a3c9cf
revert gcode_preview.cpp
classicrocker883 98ae726
revert gcode_preview.h
classicrocker883 6764626
Merge branch 'bugfix-2.1.x' into pr/26181
thinkyhead 3ee47a2
tweak style
thinkyhead 8e741cc
exit avrdude.conf - optimize spacing
classicrocker883 93c66eb
renamed to "Normal Mesh Viewer"
classicrocker883 a0557c5
small tweaks
classicrocker883 7bec91e
Merge branch 'bugfix-2.1.x' of https://github.com/MarlinFirmware/Marl…
classicrocker883 100bb82
Merge branch 'bugfix-2.1.x' into bugfix-2.1.x-redo
classicrocker883 98fd495
typo in config_adv.h
classicrocker883 675061b
rename to MSG_CHANGE_MESH - add language support
classicrocker883 ebceff1
had issue with "floating" Flow%, this a good fix??
classicrocker883 17fb167
remove/replace MSG_UBL_LEVEL_BED
classicrocker883 58e7eff
enum Buttons
classicrocker883 fecab96
should be "purge_length", not "extrude_length"
classicrocker883 5af8197
fix for `HAS_MARLINUI_MENU` unsigned int (Flow%)
classicrocker883 3335b0c
test
classicrocker883 020a22d
fix for `HAS_MARLINUI_MENU` unsigned int (Flow%)
classicrocker883 6451b2a
Merge branch 'bugfix-2.1.x-redo' of https://github.com/classicrocker8…
classicrocker883 73e46a7
revert test
classicrocker883 4c51e4d
revert flow_percentage (needs more research)
classicrocker883 9275010
revert Buttons
classicrocker883 8012d70
Merge branch 'MarlinFirmware:bugfix-2.1.x' into bugfix-2.1.x-redo
classicrocker883 2c7b4a0
revert language_xx.h, MSG_UBL_LEVEL_BED
classicrocker883 671bc8c
Merge branch 'bugfix-2.1.x-redo' of https://github.com/classicrocker8…
classicrocker883 595f5a1
Merge branch 'bugfix-2.1.x' of https://github.com/MarlinFirmware/Marl…
classicrocker883 67158da
fix USE_GRID_MESHVIEWER bedlevelTools
classicrocker883 4242ca1
forgot #endif
classicrocker883 4b76ed7
Update language_en.h, add MSG_CHANGE_MESH
classicrocker883 c21eacc
Merge branch 'bugfix-2.1.x' of https://github.com/MarlinFirmware/Marl…
classicrocker883 c8a1534
Merge branch 'bugfix-2.1.x' of https://github.com/MarlinFirmware/Marl…
classicrocker883 996fe86
Merge branch 'bugfix-2.1.x' of https://github.com/MarlinFirmware/Marl…
classicrocker883 d677952
Merge https://github.com/MarlinFirmware/Marlin into bugfix-2.1.x-redo
classicrocker883 44705e1
Update bedlevel_tools.cpp, fix error
classicrocker883 a496bae
Merge branch 'bugfix-2.1.x' of https://github.com/MarlinFirmware/Marl…
classicrocker883 47d34fa
change to !
classicrocker883 b59769d
revert - transfer various to Various small fixes PR
classicrocker883 d0abcd5
temp fix for error (read TODO:)
classicrocker883 de66cd9
Merge remote-tracking branch 'upstream/bugfix-2.1.x' into bugfix-2.1.…
classicrocker883 bf55c79
Merge branch 'bugfix-2.1.x' of https://github.com/MarlinFirmware/Marl…
classicrocker883 056af4a
Merge branch 'bugfix-2.1.x' of https://github.com/MarlinFirmware/Marl…
classicrocker883 e2e2a6c
Merge branch 'bugfix-2.1.x' of https://github.com/MarlinFirmware/Marl…
classicrocker883 b07ce9b
Merge branch 'bugfix-2.1.x' of https://github.com/MarlinFirmware/Marl…
classicrocker883 6015ca0
Merge branch 'bugfix-2.1.x' of https://github.com/MarlinFirmware/Marl…
classicrocker883 13337ec
Merge branch 'bugfix-2.1.x' of https://github.com/MarlinFirmware/Marl…
classicrocker883 3625019
Update Conditionals_post.h define meshviewer
classicrocker883 dc8c0b0
Update dwin.cpp ALL()
classicrocker883 bff5153
Merge branch 'bugfix-2.1.x' of https://github.com/MarlinFirmware/Marl…
classicrocker883 7d8c400
Merge branch 'bugfix-2.1.x' of https://github.com/MarlinFirmware/Marl…
classicrocker883 8fb56e3
Merge branch 'bugfix-2.1.x' of https://github.com/MarlinFirmware/Marl…
classicrocker883 bdfda6d
Merge branch 'bugfix-2.1.x' of https://github.com/MarlinFirmware/Marl…
classicrocker883 6975a53
remove characters causing issue with make format-pins
classicrocker883 6f4c7bc
Merge branch 'MarlinFirmware:bugfix-2.1.x' into bugfix-2.1.x-redo
classicrocker883 96819d2
Merge branch 'bugfix-2.1.x' of https://github.com/MarlinFirmware/Marl…
classicrocker883 9b81b2f
Merge https://github.com/MarlinFirmware/Marlin into bugfix-2.1.x-redo
classicrocker883 2d30a57
Merge https://github.com/MarlinFirmware/Marlin into bugfix-2.1.x-redo
classicrocker883 ba743c3
Merge branch 'bugfix-2.1.x' into bugfix-2.1.x-redo
classicrocker883 b10e1a8
Merge branch 'bugfix-2.1.x' of https://github.com/MarlinFirmware/Marl…
classicrocker883 56d6f66
Merge https://github.com/MarlinFirmware/Marlin into bugfix-2.1.x-redo
classicrocker883 377f8ff
Merge branch 'bugfix-2.1.x' of https://github.com/MarlinFirmware/Marl…
classicrocker883 b1b75aa
Merge https://github.com/MarlinFirmware/Marlin into bugfix-2.1.x-redo
classicrocker883 5991d79
Merge branch 'bugfix-2.1.x' into bugfix-2.1.x-redo
classicrocker883 e9d14cc
Merge branch 'bugfix-2.1.x' into pr/26181
thinkyhead 01225d0
Misc. cleanups
thinkyhead e25521c
use known item counts
thinkyhead 8071549
move
thinkyhead 6f4342c
minimal menu item alloc
thinkyhead 485b94d
Merge branch 'bugfix-2.1.x' into pr/26181
thinkyhead 5a98db4
rename
thinkyhead 4d76a4e
"Use Grid Style"
thinkyhead a0d892d
simplify
thinkyhead File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In what way does this "change" the mesh viewer?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there are two types of ways to view the mesh

This shows the two types of meshviewer as an exampleyou can toggle between with the checkbox
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The display with solid colors is much nicer. The display with circles seems noisy and inferior, but is it useful for people with color blindness?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anyway, you get my point. The label "Change Mesh Viewer" with a checkbox next to it is unclear and therefore bad UI design. The label should indicate what type of mesh viewer will be seen when the checkbox is checked. For example, the label "Ugly Mesh View" would make it clear that when the checkbox is checked the mesh viewer will be the "ugly" version, as opposed to the "normal" version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a valid point. I'm not partial to either, just offering making the options more available. I just wanted to say the picture examples posted aren't reminiscent of a true bed level, merely did a quick manual edit of the values to give a quick example of how it can be displayed.
this above image is more a true representation of a typical mesh.
anyway it is what it is. and as for calling it "Normal Mesh View" or something like that is a good idea. Having the checkbox enabled means to have the Square block style. default would be the box unchecked and Circle colorful style.