Enabled 2 mesh viewers

[classicrocker883]

Description

for ProUI:

This adds the option to enable two types of mesh viewers.
Toggle between the older "Red ..0.. Green" square block style and the newer rainbow color round style.

• add menu option to view 2 ways to view mesh.
• renamed to MSG_CHANGE_MESH from MSG_CHANGE_MESH_VIEWER

changed in Conditionals_post.h so USE_GRID_MESHVIEWER is defined when ProUI is used, because bedlevelTools is.
in settings.cpp, also added a couple relevant comments to other things in settings.cpp.

Requirements

DWIN_LCD_PROUI
HAS_MESH

Benefits

gives the user the option to toggle between the two ways to view the mesh.

Configurations

Related Issues

Note

in meshviewer.cpp I wrote a TODO: comment because set_status_and_level was changed in marlinui.h (which is now in the other PR).

I'm not sure which is right... either leaving how this function is defined, and just changing how it is used in meshviewer.cpp (by adding , 0) to the end of it OR level=0 as its defined).

-   ui.set_status_and_level(MString<30>(F("Mesh Z min: "), p_float_t(min, 2), F(", max: "), p_float_t(max, 2)));
// with change in marlin.h -- level=0
+   ui.set_status_and_level(MString<30>(F("Mesh Z min: "), p_float_t(min, 2), F(", max: "), p_float_t(max, 2)), 0);
// without changes 

as example

-  static void set_status_and_level(const char * const cstr, const int8_t level) { _set_status_and_level(cstr, level, false); }
+  static void set_status_and_level(const char * const cstr, const int8_t level=0) { _set_status_and_level(cstr, level, false); }

[classicrocker883]

@thisiskeithb @thinkyhead Prusa/MK3S-BigTreeTech-BTT002 has caused an issue with pull requests

(BIGTREE_BTT002) (pull_request) fails and with the given error:

Marlin\src\sd\cardreader.cpp:996:28: error: 'IS_DIR' was not declared in this scope; did you mean 'EISDIR'?
Marlin\src\sd\cardreader.cpp:1014:30: error: 'IS_DIR' was not declared in this scope; did you mean 'EISDIR'?
Marlin\src\sd\cardreader.cpp:1365:11: error: 'isDir' was not declared in this scope; did you mean 'isDigit'?

HAS_FOLDER_SORTING should be enabled, because FOLDER_SORTING became undefined in the recent push to example configs.

[thisiskeithb]

Thinkyhead will need to push a follow-up commit after checking existing configs that were broken after MarlinFirmware/Configurations@65c5120.

[thinkyhead]

The viewer_asymmetric_range flag is still referenced, so that cannot be removed just yet. If it is no longer relevant then the code that refers to it must be updated. Check with @mriscoc for advice on whether it should be retained.

[thinkyhead]

In what way does this "change" the mesh viewer?

[classicrocker883]

there are two types of ways to view the mesh

This shows the two types of meshviewer as an example

you can toggle between with the checkbox

[thinkyhead]

The display with solid colors is much nicer. The display with circles seems noisy and inferior, but is it useful for people with color blindness?

[thinkyhead]

Anyway, you get my point. The label "Change Mesh Viewer" with a checkbox next to it is unclear and therefore bad UI design. The label should indicate what type of mesh viewer will be seen when the checkbox is checked. For example, the label "Ugly Mesh View" would make it clear that when the checkbox is checked the mesh viewer will be the "ugly" version, as opposed to the "normal" version.

[classicrocker883]

The display with solid colors is much nicer. The display with circles seems noisy and inferior, but is it useful for people with color blindness?

That's a valid point. I'm not partial to either, just offering making the options more available. I just wanted to say the picture examples posted aren't reminiscent of a true bed level, merely did a quick manual edit of the values to give a quick example of how it can be displayed.

this above image is more a true representation of a typical mesh.

anyway it is what it is. and as for calling it "Normal Mesh View" or something like that is a good idea. Having the checkbox enabled means to have the Square block style. default would be the box unchecked and Circle colorful style.

[mriscoc]

The viewer_asymmetric_range flag is still referenced, so that cannot be removed just yet. If it is no longer relevant then the code that refers to it must be updated. Check with @mriscoc for advice on whether it should be retained.

I didn't see what was wrong with the thumbnail preview. Proper definitions should be ensured to allow people to choose between having a normal mesh viewer, a grid mesh viewer, or a selectable one; otherwise, we're increasing the program memory usage for no real benefit.

[classicrocker883]

I didn't see what was wrong with the thumbnail preview.

it wasnt working when I tried before I made the changes. unless I imagined it. but it was working fine after.

update: not sure what happened. thumbnail previews are working without changes made. so disregard.

[thinkyhead]

Please test to make sure nothing has been broken. I can also test this on my E3V2. I think most would prefer the square grid mesh viewer instead of the one with circles as the default because the white text is hard to read on the bright circles. Neither mesh viewer stands out as more "normal" so we can consider different labels. Maybe one is "View Mesh (grid)" and the other is "View Mesh (blobs)".

I have not used ProUI from the community fork in a couple of years, so I don't know what else may be implemented there which has not been migrated here, but we can continue to bring over missing pieces as time allows.

e.g., I grabbed code from other sources to decompress and display images embedded in G-code, experimented with that a little. So we could potentially display print previews (large and icon) once we have that code in there. It would be good to display it on the print confirmation screen.

[classicrocker883]

I grabbed code from other sources to decompress and display images embedded in G-code,

are you talking about HAS_GCODE_PREVIEW?
"Preview G-code model thumbnail"

isnt that already a feature? except I dont believe the slicer scripts/plugin have been added
you can find in How-to-generate-a-gcode-preview wiki.

I know cura has a plugin to "Create Thumbnail", im not sure if current bugfix-2.1.x ProUI is compatible with that or not. it does produce a similar code in the .gcode, it may just work over on my fork of MRicoC's ProUI

edit:
also, mriscoc's firmware has a different style Mesh Viewer. its similar to the old block one.
and the code for it is not available - locked in the library