build: restore python-neo-lzf for macOS ARM64 and limit fallback to Linux #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In v1.4.1, the dependency was switched to `python-lzf` for all ARM64 platforms to resolve installation issues. However, `python-neo-lzf` already provides Universal2 wheels for macOS (supporting Apple Silicon), so the fallback is strictly necessary only for Linux aarch64 environments where pre-built wheels are missing. This commit refines the PEP 508 environment markers to: - Use `python-lzf` ONLY on Linux aarch64/arm64. - Restore `python-neo-lzf` for macOS ARM64 (and continue using it for x86_64).
![windsurf-bot[bot]](https://avatars.githubusercontent.com/in/1066231?s=60&v=4){kind=small}
urasakikeisuke
added
rd/fix
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||
amc-nu
approved these changes
Dec 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR refines the dependency logic introduced in v1.4.1.
It restricts the fallback to
python-lzfto Linux ARM64 environments only, restoringpython-neo-lzffor macOS ARM64 (Apple Silicon) users.Motivation
As pointed out in this comment by @johnthagen,
python-neo-lzfprovides Universal2 wheels for macOS, which support ARM64.Therefore, forcing macOS users to use
python-lzfwas unnecessary. The build failure is specific to Linux aarch64 (e.g., Docker containers, Raspberry Pi) where wheels are missing.Changes
Modified
pyproject.tomlto checksys_platformin addition toplatform_machine.python-lzfon ALLarm64/aarch64python-lzfon Linux AND (arm64/aarch64)python-neo-lzfon everything else (including macOS ARM64)Verification
We have verified the installation behavior on the following physical and emulated environments:
python-neo-lzf✅python-neo-lzf✅ (Fixed)python-lzf✅ (Fallback)Future Plan
We are tracking the upstream issue: FledgeXu/python-neo-lzf#2.
Once Linux aarch64 wheels are provided by
python-neo-lzf, we will revert this fallback entirely.