-
Notifications
You must be signed in to change notification settings - Fork 12
build: use python-lzf on aarch64 to fix installation errors #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Updated dependencies to handle Arm64 platform compatibility.The dependency `python-neo-lzf` does not provide pre-built wheels for aarch64 architectures. This causes installation failures with tools like `uv` or `pip` in environments lacking a C compiler, or results in extremely slow builds under QEMU emulation. This commit modifies `pyproject.toml` to use PEP 508 environment markers: - Use `python-neo-lzf` on x86_64 (unchanged). - Switch to `python-lzf` on aarch64/arm64 platforms. This ensures smoother installation and compatibility on Arm-based devices (e.g., Raspberry Pi, AWS Graviton, Apple Silicon Docker containers).
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 🤙
💡 To request another review, post a new comment with "/windsurf-review".
|
@urasakikeisuke Are we sure this change was correct? The The macOS wheels are universal, so they should work for ARM64 macOS. As for Linux ARM64 wheels, yes those are missing. I opened an issue upstream to try to get that fixed there So I think this PR should ideally be amended to only select |
|
@johnthagen Thanks for pointing this out! You are absolutely right. Since I primarily verified this on a Linux container, I overlooked that the macOS wheels were already provided as Universal2. I will immediately submit a follow-up PR to refine the environment markers. We will configure it to fall back to python-lzf only on Linux ARM64 environments, restoring python-neo-lzf for macOS ARM64. Also, thank you for opening the issue upstream. Once that upstream issue is resolved and the Linux ARM64 wheels are published, we will revert these changes and standardize on python-neo-lzf across all platforms. |
|
@johnthagen I have released v1.4.2 on PyPI. Thanks again for your help! |
Updated dependencies to handle Arm64 platform compatibility.The dependency
python-neo-lzfdoes not provide pre-built wheels for aarch64 architectures.This commit modifies
pyproject.tomlto use PEP 508 environment markers:python-neo-lzfon x86_64 (unchanged).python-lzfon aarch64/arm64 platforms.Close #56