Skip to content

fix: make axislegend's margin themeable #5624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
awadell1 wants to merge 2 commits into
base: master
Choose a base branch
from
+22 −1
Open

fix: make axislegend's margin themeable #5624

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
24c07d7
fix: make axislegend's margin themeable
awadell1 May 9, 2026
1b44c24
tweak: explicitly check kwargs for margin
awadell1 May 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makie/src/makielayout/blocks/legend.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1128,7 +1128,7 @@ function axislegend(ax, args...; position = :rt, kwargs...)
return Legend(
ax.parent, args...;
bbox = ax.scene.viewport,
margin = (6, 6, 6, 6),
margin = something(theme(:Legend), (; margin = (6, 6, 6, 6))).margin,
Comment thread
awadell1 marked this conversation as resolved.
Outdated
legend_position_to_aligns(position)...,
kwargs...
)
Expand Down
17 changes: 17 additions & 0 deletions Makie/test/SceneLike/makielayout.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -682,3 +682,20 @@ end
end
end
end

# issue 2415
@testset "themeable axislegend" begin
f = Figure()
ax = Axis(f[1, 1])
lines!(ax, 1:10, label = "A line")
leg = @test_nowarn axislegend(ax)
@test all(>=(0), leg.margin[])
with_theme(Theme(Legend = (; margin = (1, 2, 3, 4)))) do
leg = @test_nowarn axislegend(ax)
@test leg.margin[] == (1, 2, 3, 4)

# Kwargs override theme
leg = @test_nowarn axislegend(ax; margin = (4, 3, 2, 1))
@test leg.margin[] == (4, 3, 2, 1)
end
end