Skip to content

fix: make axislegend's margin themeable#5624

Open
awadell1 wants to merge 2 commits into
MakieOrg:masterfrom
awadell1:themeable-axislegend
Open

fix: make axislegend's margin themeable#5624
awadell1 wants to merge 2 commits into
MakieOrg:masterfrom
awadell1:themeable-axislegend

Conversation

@awadell1
Copy link
Copy Markdown

Description

Fixes #2415

Update axislegend to allow for a themeable margin, falling back to the existing default. Kwarg still takes priority.

I'm suspect that this is not the ideal way to get the theme's Legend.margin entry, but I couldn't find a clear alternative.

Type of change

Delete options that do not apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • Added an entry in CHANGELOG.md (for new features and breaking changes)
  • Added or changed relevant sections in the documentation
  • Added unit tests for new algorithms, conversion methods, etc.
  • Added reference image tests for new plotting functions, recipes, visual options, etc.

Plus add test to verify that kwargs > theme > default for the
Legend's margin
@github-project-automation github-project-automation Bot moved this to Work in progress in PR review May 10, 2026
Comment thread Makie/src/makielayout/blocks/legend.jl Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Work in progress

Development

Successfully merging this pull request may close these issues.

axislegend ignores theme's margin

2 participants